Allow more configuration of the besticon package #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new Besticon struct from which all the other methods are called. This allows removing all global variables and constants and replacing them by functional options. This makes it easier to configure all options with e.g. different named environment variables. This is a breaking change since it changes how all methods need to be called. See: https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis
|
@mat I'm not sure why CodeQL is failing since there's no new code causing these violations. Are the previous ones perhaps not detected or ignored? |
Not detected I'm afraid :-( Let's deal with them separately later… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Besticon struct from which all the other methods
are called. This allows removing all global variables and constants
and replacing them by functional options. This makes it easier to
configure all options with e.g. different named environment variables.
This is a breaking change since it changes how all methods need to be
called.
Something which is not in this PR but may be useful is to remove the
IconFinderand change it to be aFetchIconsmethod on theBesticonstruct which takes functional options as well.
See: https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis