Adding CI, fixing large arrays #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
matajoh
force-pushed
the
large_file_fix
branch
from
34b1fd8 to
ed61d96
Compare
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
matajoh
force-pushed
the
large_file_fix
branch
from
4cd9a22 to
4a07715
Compare
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
matajoh
force-pushed
the
large_file_fix
branch
from
ae46ca2 to
30621e7
Compare
Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
matajoh
added a commit
that referenced
this pull request
Nov 2, 2024
Improvements: - Increased CHUNK size as per miniz instructions - Added tests for very large arrays in NPZ files - Added some CI tests to catch issues across platforms - Removed the internal IO streams in favor of just using stringstream - NPZs can now be read from and written to memory Bugfixes: - Fixed an issue where very large arrays in NPZ files would throw an error - Fixed a bug with mac builds due to deprecated APIs Signed-off-by: Matthew Johnson <matthew@matthewajohnson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Bugfixes:
Fixes #32
Fixes #30
Fixes #29