Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Go development versions format incorrectly #137

Closed
matchai opened this issue Jan 16, 2019 · 1 comment · Fixed by #142
Closed

Go development versions format incorrectly #137

matchai opened this issue Jan 16, 2019 · 1 comment · Fixed by #142
Labels
Good First Issue Good for newcomers Status: Available Status: Released Type: Bug Fix an existing bug

Comments

@matchai
Copy link
Owner

matchai commented Jan 16, 2019 •
edited by spacefish-bot bot
Loading

It appears the following Spaceship ZSH issue would carry over to the Spacefish, as our Go implementation matches theirs.

Please take a look at the fix addressing this issue at spaceship-prompt/spaceship-prompt#611

🐟 spacefish-bot — Issue copied from: spaceship-prompt/spaceship-prompt#610.

Current behavior

The version is cut off (~ via 🐹 vvel)

Expected behavior

~ via 🐹 devel +5efe9a8f11

Relevant Zsh configuration (.zshrc)

N/A

Environment

Spaceship version: 3.9.1
Zsh version: zsh 5.3 (x86_64-apple-darwin18.0)
Zsh framework: oh-my-zsh @ fabee559
Zsh plugin manager: None
Terminal emulator: iTerm
Operating system: macOS

Screenshot

Provide a screenshot that shows your issue.

screen shot 2019-01-11 at 12 47 47

Possible solution

See expected behavior.
@matchai matchai added Type: Bug Fix an existing bug Good First Issue Good for newcomers Status: Available labels Jan 16, 2019
@spacefish-bot spacefish-bot bot changed the title #610 Go development versions format incorrectly Jan 16, 2019
matchai added a commit that referenced this issue Jan 16, 2019
@matchai
fix: correct go development version format
df89470 
Closes #137
@matchai matchai mentioned this issue Jan 16, 2019
Merged
10 tasks
matchai added a commit that referenced this issue Jan 23, 2019
@matchai
fix: correct go development version format
e678ac2 
Closes #137
matchai pushed a commit that referenced this issue Jan 23, 2019
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
0325ff5 
# [2.1.0](v2.0.1...v2.1.0) (2019-01-23)

### Bug Fixes

* correct go development version format ([e678ac2](e678ac2)), closes [#137](#137)

### Features

* improve pyenv version detection ([22b9e20](22b9e20)), closes [#140](#140)
* provide docker version if in a docker container ([62891b4](62891b4)), closes [#138](#138)
@matchai
Copy link
Owner Author

matchai commented Jan 23, 2019

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Status: Available Status: Released Type: Bug Fix an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Squash a few issues from recent Spacefish releases 🐛 matchai/spacefish
1 participant
@matchai