This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
style: run fish_indent on all *.fish files #144
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having ran
fish_indent
on all the fish files in the project, our fish files should be more consistently indented and formatted in the fish style.You may notice that early returns are now on a new line. I personally don't mind this change, but I can see it bothering others. In the end, I'm happy with anything as long as it's consistent. If we agree to the styling of
fish_indent
, it may be worthwhile to add it as a git hook on *.fish files with Husky. Thoughts?Another quick note is that test files have not been formatted. It is a known issue that fish-tape files are not fish_indent compatible, so I reindented them to fit with the 4-space indentation of
fish_indent
.Click here for the non-whitespace changes! ✨
Types of changes
How Has This Been Tested?
Checklist: