[hue] Fix migration of API v1 legacy data to new v2 things (openhab#1…

…6714) Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews · Oct 18, 2024 · 4176c73 · 4176c73
1 parent 173fe88
commit 4176c73
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/...nding.hue/src/main/java/org/openhab/binding/hue/internal/console/HueCommandExtension.java b/...nding.hue/src/main/java/org/openhab/binding/hue/internal/console/HueCommandExtension.java
@@ -203,7 +203,6 @@ public void execute(String[] args, Console console) {
                                         Optional<Thing> legacyThingOptional = clip2BridgeHandler.getLegacyThing(idv1);
                                         if (legacyThingOptional.isPresent()) {
                                             Thing legacyThing = legacyThingOptional.get();
-                                            thingId = legacyThing.getUID().getId();
                                             String legacyLabel = legacyThing.getLabel();
                                             thingLabel = Objects.nonNull(legacyLabel) ? legacyLabel : thingLabel;
                                         }

diff --git a/.../src/main/java/org/openhab/binding/hue/internal/discovery/Clip2ThingDiscoveryService.java b/.../src/main/java/org/openhab/binding/hue/internal/discovery/Clip2ThingDiscoveryService.java
@@ -121,7 +121,6 @@ private synchronized void discoverThings() {
                         if (legacyThingOptional.isPresent()) {
                             Thing legacyThing = legacyThingOptional.get();
                             legacyThingUID = legacyThing.getUID().getAsString();
-                            thingId = legacyThing.getUID().getId();
                             String legacyLabel = legacyThing.getLabel();
                             thingLabel = Objects.nonNull(legacyLabel) ? legacyLabel : thingLabel;
                         }

diff --git a/...inding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2BridgeHandler.java b/...inding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2BridgeHandler.java
@@ -366,13 +366,11 @@ public Optional<Thing> getLegacyThing(String targetIdV1) {
         }
 
         ThingUID legacyBridgeUID = legacyBridge.get().getUID();
-        return thingRegistry.getAll().stream() //
+        return thingRegistry.getAll().stream()
                 .filter(thing -> legacyBridgeUID.equals(thing.getBridgeUID())
-                        && V1_THING_TYPE_UIDS.contains(thing.getThingTypeUID())) //
-                .filter(thing -> {
-                    Object id = thing.getConfiguration().get(config);
-                    return (id instanceof String) && targetIdV1.endsWith("/" + (String) id);
-                }).findFirst();
+                        && V1_THING_TYPE_UIDS.contains(thing.getThingTypeUID())
+                        && thing.getConfiguration().get(config) instanceof String id && targetIdV1.endsWith("/" + id))
+                .findFirst();
     }
 
     /**