Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --MAIN-HOVER-color #111

Closed
mdavids opened this issue Jan 22, 2018 · 3 comments
Closed

Missing --MAIN-HOVER-color #111

mdavids opened this issue Jan 22, 2018 · 3 comments

Comments

@mdavids
Copy link
Contributor

mdavids commented Jan 22, 2018

Theme theme-blue.css, theme-red.css and theme-green.css refer to MAIN-HOVER-color:

background-color: var(--MAIN-HOVER-color);

however, they don't define it.

As a result of this the animation of the line beneath links (when hovered over), does not work.

An easy fix is to add MAIN-HOVER-color.

In theme-blue.css this would be something like:

--MAIN-HOVER-color:#167ad0; /* Color of hovered links animation ul */

This is the color used in --MAIN-LINK-HOVER-color
(the other themes can be fixed likewise).

Another, probably more appropriate solution would be to change:

background-color: var(--MAIN-HOVER-color);
into
background-color: var(--MAIN-LINK-HOVER-color);

@matcornic
Copy link
Owner

Well spotted. Would you want to make a PR ?

@mdavids
Copy link
Contributor Author

mdavids commented Jan 22, 2018

Sorry for adding the PR's as separate issues, could probably have been done more efficient ;-)

matcornic added a commit that referenced this issue Jan 23, 2018
matcornic added a commit that referenced this issue Jan 23, 2018
matcornic added a commit that referenced this issue Jan 23, 2018
matcornic added a commit that referenced this issue Jan 23, 2018
matcornic added a commit that referenced this issue Jan 23, 2018
matcornic added a commit that referenced this issue Jan 23, 2018
@matcornic
Copy link
Owner

@mdavids thanks !

sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
sbamin pushed a commit to sbamin/docstheme-hugo-learn that referenced this issue Jul 29, 2018
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants