Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Hugo version 0.23 #51

Closed
ghost opened this issue Jun 20, 2017 · 8 comments
Closed

Update to Hugo version 0.23 #51

ghost opened this issue Jun 20, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Jun 20, 2017

Starting with Hugo version 0.22 .Site.Sections is not working anymore. Switch to proposal from

https://github.com/gohugoio/hugo/blob/master/hugolib/site_sections.go#L34

@vcastellm
Copy link

This renders in this theme only working in the rage of >= 0.19 < 0.22

@vielmetti
Copy link

vielmetti commented Jul 5, 2017

I ran into this today, using hugo 0.24.1 from Homebrew.

@vcastellm
Copy link

All issues seems to be solved in this fork https://github.com/vjeantet/hugo-theme-docdock

@anthonyfok
Copy link

Hi @matcornic,

Please try to find time to resolve this issue ASAP, as some end user (friend or foe? 😉) is already requesting the removal of your theme from themes.gohugo.io, see gohugoio/hugo#3697

As @Victorcoder has kindly suggested, the issue has been solved in the fork https://github.com/vjeantet/hugo-theme-docdock

Many thanks!

@matcornic matcornic self-assigned this Jul 22, 2017
@matcornic matcornic added the bug label Jul 22, 2017
@matcornic
Copy link
Owner

Hey everyone!

I just mentioned this big issue in the README of the project to better warn users. This issue will need a lot of work to be done (it's like a complete rewrite). We need to change menu, automatic arrows and breadcrumbs display.

I may rewrite all the theme from code of the great docdock fork.

And thanks for the heads up @anthonyfok, but I don't mind haters ^^ (I only focus on contributors)

@matcornic matcornic added this to the 2.0.0 milestone Jul 22, 2017
@anthonyfok
Copy link

And thanks for the heads up @anthonyfok, but I don't mind haters ^^ (I only focus on contributors)

That's awesome! Thank you @matcornic!

I wrote a comment at gohugoio/hugo#3697 and closed the issue. 😆

@matcornic
Copy link
Owner

Fixed in v2 milestone

matcornic added a commit that referenced this issue Aug 20, 2017
@matcornic
Copy link
Owner

@anthonyfok @m0d00d @Victorcoder @vielmetti I just released v2, give it a Go https://learn.netlify.com/en/ !

dcrankshaw pushed a commit to dcrankshaw/hugo-theme-learn that referenced this issue Sep 13, 2017
Do not wrap images that already wrapped in a link. Closes matcornic#42
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants