Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selector does not work with sub-folders in baseURL #65

Open
bep opened this issue Sep 4, 2017 · 4 comments
Open

Language selector does not work with sub-folders in baseURL #65

bep opened this issue Sep 4, 2017 · 4 comments
Assignees

Comments

@bep
Copy link

bep commented Sep 4, 2017

See https://themes.gohugo.io/theme/hugo-theme-learn/en

@matcornic
Copy link
Owner

@bep thanks for the feedback !

@matcornic matcornic added the bug label Sep 4, 2017
@matcornic matcornic self-assigned this Sep 4, 2017
@matcornic
Copy link
Owner

Hey @bep, is there a special configuration in the themes website that this theme does not handle well ?

I tried locally by setting baseURL = "http://localhost:1313/some/sub/folders" and it works pretty well : http://recordit.co/2zpgJSpP5w

@bep
Copy link
Author

bep commented Sep 5, 2017

I have fixed the deploy previews on the theme repo, so I suggest you do the debugging with creating a PR and mark it as a "work in progress" or something. I don't have time to spend more time on this.

@bep
Copy link
Author

bep commented Sep 5, 2017

A quick glance at your code I notice you do manual URL building with baseURL.

I recommend you use:

  • relURL, absURL, relLangURL or absLangURL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants