Update Font Awesome to 5.0.6 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, it's a very nice PR! I would prefer local assets though. This kind of documentation theme can be used in private networks that do not have Internet access. So, we should avoid having assets loaded from Internet. |
|
Ok I didn't consider offline use on private network. I'll bring assets back into local. |
|
Loading the new CSS file, the name of which changed to The css loads the fonts from the path |
|
Bump. Any possibility of getting this pushed through? |
|
@matcornic Also bumping, it would be awesome if this PR was merged. |
|
Merge, I updated to 5.2.0 too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a specific icon which was only made available in v5 of FontAwesome so I went ahead and upgraded the sitewide version.
With v5 there's no longer any need to keep the binary files locally, they are all loaded remotely, so this PR deletes all the local FA assets.InIn v5 the icons have been split fromlayouts/partials/header.htmlI load the remote CSS.faintofas(fontawesome solid) andfab(fontawesome brands). There's a shim to ease transition to v5 but I just replaced all the selectors to point to the new icons so I am NOT loading the upgrade shim. Full v4 to v5 docs are here: https://fontawesome.com/how-to-use/upgrading-from-4I also wrote a help page on how to include icons. As a user I was not aware the theme loaded fontawesome before I really dug into the source code. It's only in English, sorry i don't speak French :)