Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load main site logo via BaseUrl #185

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Load main site logo via BaseUrl #185

merged 1 commit into from
Oct 24, 2018

Conversation

ChrisLasar
Copy link
Contributor

This might ease the adaptation of the theme for Hugo newbies like me ;)

This might ease the adaptation of the theme for Hugo newbies like me ;)
@matalo33
Copy link
Contributor

I did some validation that there wasn't a hugo object for the home page and not just the BaseUrl but I can't see a suitable value. BaseUrl will work in most cases, and is an improvement on the getgrav address, but can't say for sure it will work nicely with all setups (e.g. uglyurls, relativelinks, etc.)

Discussed further at gohugoio/hugo#4642

@matalo33 matalo33 merged commit 13d77a1 into matcornic:master Oct 24, 2018
@matalo33 matalo33 changed the title Logo links BaseUrl now Load main site logo via BaseUrl Jan 28, 2019
@matalo33 matalo33 added the enhancement Improvements to existing features label Jan 28, 2019
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants