Implement login & findByEmail methods #1101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MentorMateAcademy
suggested changes
Sep 18, 2024
| * @param password - user's password | ||
| * @return true if user by email exists and passed password is equal to user's password. | ||
| * Return false in any other cases. | ||
| */ | ||
| public boolean login(String email, String password) { | ||
| User user = new UserService().findByEmail(email); |
There was a problem hiding this comment.
UserService should be class level variable
Comment on lines
18
to
21
| if (user != null && user.getEmail().equals(email) && user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
try to use one return and condition
JJJazl
suggested changes
Oct 10, 2024
| * @param password - user's password | ||
| * @return true if user by email exists and passed password is equal to user's password. | ||
| * Return false in any other cases. | ||
| */ | ||
| private final UserService userService = new UserService(); |
There was a problem hiding this comment.
- You have to declare variable before java doc for method
- It's better to use a constructor
okuzan
approved these changes
Oct 10, 2024
okuzan
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.