-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement login & findByEmail methods #1101
base: master
Are you sure you want to change the base?
Implement login & findByEmail methods #1101
Conversation
* @param password - user's password | ||
* @return true if user by email exists and passed password is equal to user's password. | ||
* Return false in any other cases. | ||
*/ | ||
public boolean login(String email, String password) { | ||
User user = new UserService().findByEmail(email); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UserService should be class level variable
if (user != null && user.getEmail().equals(email) && user.getPassword().equals(password)) { | ||
return true; | ||
} | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to use one return and condition
* @param password - user's password | ||
* @return true if user by email exists and passed password is equal to user's password. | ||
* Return false in any other cases. | ||
*/ | ||
private final UserService userService = new UserService(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You have to declare variable before java doc for method
- It's better to use a constructor
No description provided.