jv-oop-lesson-0 #1116
Open
jv-oop-lesson-0 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Oct 8, 2024
Comment on lines
23
to
38
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| User user = (User) o; | ||
| return Objects.equals(email, user.email) | ||
| && Objects.equals(password, user.password); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(email, password); | ||
| } |
Comment on lines
15
to
17
| if (userService.findByEmail(email) != null) { | ||
| return userService.findByEmail(email).getPassword().equals(password); | ||
| } |
There was a problem hiding this comment.
don't search twice, save result of the search to a local variable
| @@ -11,6 +11,10 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
create it on a class level, not a method level
ahoienko
suggested changes
Oct 9, 2024
| public boolean login(String email, String password) { | ||
| User user = userService.findByEmail(email); // Save the result to a variable |
There was a problem hiding this comment.
Suggested change
| User user = userService.findByEmail(email); // Save the result to a variable | |
| User user = userService.findByEmail(email); |
| @@ -16,4 +16,5 @@ public String getEmail() { | |||
| public String getPassword() { | |||
| return password; | |||
| } | |||
|
|
|||
Elena-Bruyako
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.