implement login method #1123
Open
implement login method #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Oct 23, 2024
Comment on lines
6
to
13
|
|
||
| private final UserService userService; | ||
|
|
||
| public AuthenticationService(UserService userService) { | ||
| this.userService = userService; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| private final UserService userService; | |
| public AuthenticationService(UserService userService) { | |
| this.userService = userService; | |
| } | |
| private final UserService userService = new UserService(); |
Comment on lines
25
to
32
| if (user == null) { | ||
| return false; | ||
| } | ||
| String userPassword = user.getPassword(); | ||
| if (userPassword.equals(password)) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (user == null) { | |
| return false; | |
| } | |
| String userPassword = user.getPassword(); | |
| if (userPassword.equals(password)) { | |
| return true; | |
| } | |
| return false; | |
| return user != null && user.getPassword().equals(password); |
src/main/java/mate/academy/Main.java
Outdated
| @@ -1,9 +1,10 @@ | |||
| package mate.academy; | |||
|
|
|||
| import mate.academy.service.AuthenticationService; | |||
| import mate.academy.service.UserService; | |||
There was a problem hiding this comment.
remove import
Suggested change
| import mate.academy.service.UserService; |
src/main/java/mate/academy/Main.java
Outdated
|
|
||
| public class Main { | ||
| private static final AuthenticationService authenticationService = new AuthenticationService(); | ||
| private static final AuthenticationService authenticationService = new AuthenticationService(new UserService()); |
There was a problem hiding this comment.
Suggested change
| private static final AuthenticationService authenticationService = new AuthenticationService(new UserService()); | |
| private static final AuthenticationService authenticationService = new AuthenticationService(); |
| @@ -5,7 +5,7 @@ | |||
| public class UserService { | |||
| private static final User[] users = new User[] { | |||
| new User("bob@i.ua", "1234"), | |||
| new User("alice@i.ua", "1234") | |||
| new User("alice@i.ua", "1234"), | |||
There was a problem hiding this comment.
remove comma
Suggested change
| new User("alice@i.ua", "1234"), | |
| new User("alice@i.ua", "1234") |
Elena-Bruyako
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.