Develop #668
Open
Develop #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aionova
suggested changes
Mar 23, 2021
src/index.html
Outdated
| <!-- <h1>Enclosures</h1> --> | ||
| <div id="qa-block" class ="outer"> | ||
| <div class="med"> | ||
| <div class="inner">In programming languages, a closure is a technique for implementing lexically scoped name binding in a language with first-class functions. Operationally, a closure is a record storing a function together with an environment.</div> |
There was a problem hiding this comment.
don't make lines longer than 80 symbols
| } | ||
|
|
||
| .outer { | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
set box-sizing: border-box to all the elements with "*" selector
src/index.html
Outdated
| </div > | ||
| <div class ="outer"> | ||
| <div class="med"> | ||
| <div class="inner">У програмуванні замиканням називають підпрограму, що виконується в середовищі, яке містить одну або більше зв’язаних змінних. Підпрограма має доступ до цих змінних під час виконання.</div> |
There was a problem hiding this comment.
Suggested change
| <div class="inner">У програмуванні замиканням називають підпрограму, що виконується в середовищі, яке містить одну або більше зв’язаних змінних. Підпрограма має доступ до цих змінних під час виконання.</div> | |
| <div class="inner"> | |
| У програмуванні замиканням називають підпрограму, що виконується в середовищі, яке містить одну | |
| або більше зв’язаних змінних. Підпрограма має доступ до цих змінних під час виконання. | |
| </div> |
| padding: 10px; | ||
| margin: 40px 20px; | ||
| background-color: #0090c2; | ||
| border: 1px solid #e95d49; |
There was a problem hiding this comment.
if border is the same for all the containers, then why not create another class for all the containers and write border there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK