Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enclosures proj #671

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RuslanaPodshyvalova
Copy link

DEMO LINK
TEST REPORT LINK

The project hasn't passed tests.
But project results are the same with pattern according to PerfectPixel.

src/index.html Outdated
<body>
<div class="blue-box bordered">
<div class="yellow-box bordered">
<p id="qa-block" class="grey-box bordered">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add id="qa-block" to the outer block and test the result again, it should work after you do this

src/style.css Outdated
}

.blue-box {
box-sizing: border-box;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add box-sizing: border-box rule to all elements on the page (use * selector for this)

src/index.html Outdated
<div class="blue-box bordered">
<div class="yellow-box bordered">
<p class="grey-box bordered">
У програмуванні замиканням називають підпрограму, що виконується в середовищі, яке містить одну або більше зв’язаних змінних. Підпрограма має доступ до цих змінних під час виконання.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch today's lecture till minute 8 and set the right formatting to your VScode, such long text should be wrapped to the new line
https://www.youtube.com/watch?v=ScTyxXA8SA8&list=PL7FuXFaDeEX0sQ0Zhwk2ixfwS1P6e0iuW&index=5

…r all elements is set up; 3)the max size for code line is set up in vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants