Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1880

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Develop #1880

wants to merge 15 commits into from

Conversation

Valbel93
Copy link

@Valbel93 Valbel93 commented Dec 17, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo, also, you need to add demo link to the PR description
image

@Valbel93
Copy link
Author

@Valbel93
Copy link
Author

DEMO LINK

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

number should appear on hover
image

  1. add some favicon
image
  1. don't forget to follow this file https://github.com/mate-academy/layout_landing-page/blob/main/checklist.md

@Valbel93 Valbel93 requested a review from etojeDenys December 17, 2024 21:04
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

Pay attention on checklist

  • Change text color on hover for phone, email, and address
  • Make sure phone icons and phone numbers are real links to start a call. Click on email should start to write email.
  • All addresses should be links to some location on Google Maps. Open them in a new tab with target="_blank".
  • Increase all images on hover (make them links to #, if there is no better option)
  • The page shouldn't be reloaded on form submit, but the fields should be cleared (now nothing happened on form submit)

Check other points from checklist.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
To improve:

  1. Add a better favicon on the page
image
  1. Fix font size everywhere
image
  1. Add transition for hover effects everywhere
image
  1. Fix gap here
image
  1. Fix line-height here
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. This comment still not fixed, you need to add transition for hover effects everywhere
image

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants