Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing #2020

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Landing #2020

wants to merge 5 commits into from

Conversation

AndrewT98
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Add hover effects for all images
image
  1. Fix height for the inputs, check it on the design
image
  1. Fix default background color for this button
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. This elements should be textarea
image
  1. Add hover effects here
image
  1. You need to reset form fields after submit the form
image
  1. Need to fix the horizontal scroll on the mobile version
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2025-02-05 at 13 39 33
  • The form jumps on fields hover. Consider fixing it
  • A user shouldn't be able to resize the text area
  • Screenshot 2025-02-05 at 13 39 22
  • There is no need to open the phone link in the new tab
  • Screenshot 2025-02-05 at 13 39 04
  • All hovers should be smooth

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, to improve:

  1. The images shouldn't overlap each other when hovering
image
  1. The autofill styles look different, the all styles should be are same
image
  1. Make all these fields are required before sending
image
  1. Check gap between these blocks
image
  1. Fix the mobile version
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants