Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2030

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Develop #2030

wants to merge 9 commits into from

Conversation

DariaRadtkina
Copy link

Copy link

@KosolapovAnatolii KosolapovAnatolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Fix small commnets and I'll send you video-review with small issues

Comment on lines 50 to 96
.form {
&__input {
height: 48px;
background-color: $form-bg-color;
color: $main-text-color;
font-size: 14px;
font-weight: 400;
line-height: 20px;
letter-spacing: $main-letter-spacing;
width: 100%;
box-sizing: border-box;
margin-bottom: 16px;
padding: 14px 16px;
border-radius: 8px;
border: 1px solid transparent;

@include hover(border, 1px solid #dbdbdb);

&:focus,
&:focus-visible {
outline: none;
border: 2px solid $theme-color;
border-radius: 8px;
}
}
&__textarea {
width: 100%;
resize: none;
background-color: $form-bg-color;
color: $main-text-color;
box-sizing: border-box;
font-family: Manrope, sans-serif;
margin-bottom: 32px;
padding: 14px 16px;
border-radius: 8px;
border: 1px solid transparent;

@include hover(border, 1px solid #dbdbdb);

&:focus,
&:focus-visible {
outline: none;
border: 2px solid $theme-color;
border-radius: 8px;
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to separate file

Comment on lines 98 to 130
.contacts {
&__item {
margin: 0;
margin-bottom: 24px;
display: block;

&:last-child {
margin-bottom: 0;
}
}

&__title {
display: block;
color: $contacts-text-color;
font-size: 14px;
font-weight: 400;
line-height: 20px;
letter-spacing: $main-letter-spacing;
margin-bottom: 8px;
}

&__description {
display: block;
color: $description-text-color;
font-size: 16px;
font-weight: 400;
line-height: 22px;
letter-spacing: $main-letter-spacing;
text-decoration: none;

@include hover(color, $theme-color);
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to separate file

Comment on lines 33 to 72
.button {
@include page-grid;

&__link {
grid-column: span 2;

@include on-tablet {
grid-column: span 6;
}

@include on-desktop {
grid-column: span 4;
}

&--footer {
grid-column: span 12;
}

display: flex;
justify-content: center;
align-items: center;
border: none;

padding: 0 48px;
height: $button-height;
border-radius: 8px;
background-color: $theme-color;
color: #fff;

font-size: 16px;
font-weight: 700;
line-height: 27px;

@include hover(background-color, #1b2129);

&:active {
background-color: #010810;
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to separate file

Comment on lines 21 to 23
.product__photo {
@include hover(transform, scale(1.1));
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's here instead of product.scss?

Comment on lines -1 to -3
body {
margin: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use this, rename this file reset.scss and move to utils folder. If you don't use, remove this file

src/index.html Outdated
@@ -1,22 +1,452 @@
<!-- #region head -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra comment before build

Copy link

@KosolapovAnatolii KosolapovAnatolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🔥 🚒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants