-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #2030
base: main
Are you sure you want to change the base?
Develop #2030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Fix small commnets and I'll send you video-review with small issues
src/styles/blocks/footer.scss
Outdated
.form { | ||
&__input { | ||
height: 48px; | ||
background-color: $form-bg-color; | ||
color: $main-text-color; | ||
font-size: 14px; | ||
font-weight: 400; | ||
line-height: 20px; | ||
letter-spacing: $main-letter-spacing; | ||
width: 100%; | ||
box-sizing: border-box; | ||
margin-bottom: 16px; | ||
padding: 14px 16px; | ||
border-radius: 8px; | ||
border: 1px solid transparent; | ||
|
||
@include hover(border, 1px solid #dbdbdb); | ||
|
||
&:focus, | ||
&:focus-visible { | ||
outline: none; | ||
border: 2px solid $theme-color; | ||
border-radius: 8px; | ||
} | ||
} | ||
&__textarea { | ||
width: 100%; | ||
resize: none; | ||
background-color: $form-bg-color; | ||
color: $main-text-color; | ||
box-sizing: border-box; | ||
font-family: Manrope, sans-serif; | ||
margin-bottom: 32px; | ||
padding: 14px 16px; | ||
border-radius: 8px; | ||
border: 1px solid transparent; | ||
|
||
@include hover(border, 1px solid #dbdbdb); | ||
|
||
&:focus, | ||
&:focus-visible { | ||
outline: none; | ||
border: 2px solid $theme-color; | ||
border-radius: 8px; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to separate file
src/styles/blocks/footer.scss
Outdated
.contacts { | ||
&__item { | ||
margin: 0; | ||
margin-bottom: 24px; | ||
display: block; | ||
|
||
&:last-child { | ||
margin-bottom: 0; | ||
} | ||
} | ||
|
||
&__title { | ||
display: block; | ||
color: $contacts-text-color; | ||
font-size: 14px; | ||
font-weight: 400; | ||
line-height: 20px; | ||
letter-spacing: $main-letter-spacing; | ||
margin-bottom: 8px; | ||
} | ||
|
||
&__description { | ||
display: block; | ||
color: $description-text-color; | ||
font-size: 16px; | ||
font-weight: 400; | ||
line-height: 22px; | ||
letter-spacing: $main-letter-spacing; | ||
text-decoration: none; | ||
|
||
@include hover(color, $theme-color); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to separate file
src/styles/blocks/main.scss
Outdated
.button { | ||
@include page-grid; | ||
|
||
&__link { | ||
grid-column: span 2; | ||
|
||
@include on-tablet { | ||
grid-column: span 6; | ||
} | ||
|
||
@include on-desktop { | ||
grid-column: span 4; | ||
} | ||
|
||
&--footer { | ||
grid-column: span 12; | ||
} | ||
|
||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
border: none; | ||
|
||
padding: 0 48px; | ||
height: $button-height; | ||
border-radius: 8px; | ||
background-color: $theme-color; | ||
color: #fff; | ||
|
||
font-size: 16px; | ||
font-weight: 700; | ||
line-height: 27px; | ||
|
||
@include hover(background-color, #1b2129); | ||
|
||
&:active { | ||
background-color: #010810; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to separate file
src/styles/blocks/recommended.scss
Outdated
.product__photo { | ||
@include hover(transform, scale(1.1)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's here instead of product.scss?
body { | ||
margin: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use this, rename this file reset.scss and move to utils folder. If you don't use, remove this file
src/index.html
Outdated
@@ -1,22 +1,452 @@ | |||
<!-- #region head --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra comment before build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥 🔥 🚒
Прев'ю - https://dariaradtkina.github.io/layout_landing-page/
Дизайн - B&O