landing page MYBike #2033
Open
landing page MYBike #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Ohirok
commented
Feb 6, 2025
•
R-Ohirok
commented
- DEMO LINK
- DESIGN: (https://www.figma.com/design/NZQAIydtHo5QkINyGLHNcq/BIKE-New-Version?node-id=41317-96&t=x7ZvE8YTsqLgZDQB-0)
KosolapovAnatolii
suggested changes
Feb 7, 2025
There was a problem hiding this comment.
Good job! Looks really amazing!
Fix things that I mentioned, and also fix few issues than I showed you on this video: https://www.loom.com/share/54e773497b5243b38d12731a5121edbf?sid=56ff264c-547b-4a4a-9f63-bb4d18787750
src/styles/blocks/details.scss
Outdated
Comment on lines
13
to
58
| .detail { | ||
| &__photos { | ||
| @include page-grid; | ||
|
|
||
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| &__link { | ||
| position: relative; | ||
| &--wide { | ||
| @include on-tablet { | ||
| grid-column: span 4; | ||
| } | ||
|
|
||
| @include on-desktop { | ||
| grid-column: span 8; | ||
| } | ||
| } | ||
|
|
||
| &--square { | ||
| height: 0; | ||
| padding-bottom: 100%; | ||
|
|
||
| @include on-tablet { | ||
| grid-column: span 2; | ||
| } | ||
|
|
||
| @include on-desktop { | ||
| grid-column: span 4; | ||
| } | ||
| } | ||
|
|
||
| @include hover(transform, scale(1.05)); | ||
| } | ||
|
|
||
| &__photo { | ||
| position: absolute; | ||
| width: 100%; | ||
| height: 100%; | ||
| object-fit: cover; | ||
| } | ||
|
|
||
| &__title { | ||
| margin: 0; | ||
| } | ||
| } |
src/styles/blocks/details.scss
Outdated
Comment on lines
60
to
90
| .explore { | ||
| @include page-grid; | ||
|
|
||
| &__button { | ||
| grid-column: 1 / 3; | ||
|
|
||
| height: 56px; | ||
| line-height: 56px; | ||
| font-size: 16px; | ||
| font-weight: $bold-font-weight; | ||
|
|
||
| text-decoration: none; | ||
| text-align: center; | ||
| align-self: center; | ||
|
|
||
| background-color: #fff; | ||
| border: 1px solid #fff; | ||
| border-radius: 40px; | ||
| color: $dark-text-color; | ||
|
|
||
| @include on-tablet { | ||
| grid-column: 2 / 6; | ||
| } | ||
|
|
||
| @include on-desktop { | ||
| grid-column: 5 / 9; | ||
| } | ||
|
|
||
| @include shadow; | ||
| } | ||
| } |
src/styles/blocks/header.scss
Outdated
| @@ -0,0 +1,49 @@ | |||
| /* #region header */ | |||
| .header { | |||
| // display: none !important; | |||
src/styles/blocks/header.scss
Outdated
| } | ||
| } | ||
|
|
||
| /* #endregion */ |
src/styles/blocks/icon.scss
Outdated
| @@ -0,0 +1,57 @@ | |||
| /* #region icon */ | |||
src/styles/blocks/icon.scss
Outdated
| } | ||
| } | ||
|
|
||
| /* #endregion */ |
There was a problem hiding this comment.
remove comments here and in all another cases
src/styles/blocks/page.scss
Outdated
Comment on lines
2
to
15
| h3 { | ||
| font-size: $bold-text-size; | ||
| font-weight: $bold-font-weight; | ||
| line-height: $bold-line-height; | ||
| } | ||
|
|
||
| a { | ||
| color: $light-text-color; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| p { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
make separate file, for example reset.scss or extends.scss for this styles
alexander-ignatow
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.