Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #2053

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Develop #2053

wants to merge 8 commits into from

Conversation

lucasschumann
Copy link

@lucasschumann lucasschumann commented Feb 8, 2025 •
edited
Loading

DanielCamposDevX
DanielCamposDevX suggested changes Feb 10, 2025
View reviewed changes
Copy link

@DanielCamposDevX DanielCamposDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase all images on hover (make them links to #)
Placeholders should give examples of what should be added, to make the expected format clear
The page shouldn't go to the top on submit. but the fields should be cleared. Go to the checklist for details.

DanielCamposDevX
DanielCamposDevX approved these changes Feb 12, 2025
View reviewed changes
Copy link

@DanielCamposDevX DanielCamposDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Remember just to not scale the elements too much on hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielCamposDevX DanielCamposDevX DanielCamposDevX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasschumann @DanielCamposDevX