-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layout miami - bose version #2587
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, provide the demo link in PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep up the good work! Some comments to fix:
-
make this number reachable, and change color according design
-
change favicon to B&O logo, now you have mateAcademy logo
-
remove outline and default autocomplete background-color, it breaks design
-
make all form fields required
-
add smooth scroll for page, now user navigate to part page immediately from nav menu
Hello, i need some help. I did some commits and pushed it to the develop branch like usual. Now i cant see new version of github page deployed although it says in vsc that everything went good. Can you tell me what i did wrong? I think i did everthing the same way like all this times befere and i dont know why is it not working :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of previous review comments, that are not fixed. Feel free to ask for help in the chat
I am aware, i fixed it and wanted to deploy gh page and i isnt working and i dont know why :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your page
- Add a placeholder text to the textarea
- Need to remove the autocomplete styles and fix the left indent for the textarea
- No need to show data from form in the url
- The color of the phone's text does not match the one on the design
- Need to remove the scroll when this menu is open
I fixed most of them except for scroling while menu is open but i cant deploy new page. It would help if someboby read this comment instead of asking me to fix the same things again.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fixed from the previous review, if you have any problems feel free in the fe_chat
I didnt notice, in task descripion, requirement to make pull request after every block. I did make commits after every block and significant change but didnt make pull requests. I hope it is not big problem and now i have almost ready site in one go.
DEMO LINK