-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOSE landing page #2594
base: master
Are you sure you want to change the base?
BOSE landing page #2594
Conversation
For now it's only styled for mobile (320px) |
Now I have to work on menu, styles for buttons and inputs, then I'll make it responsive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You page should work one every mobile device, so you can't just go: "it works on 320px mobile"
Using hard-coded values for things like navbar is a bad idea:
.header { grid-template-columns: repeat(2,130px);}
it will make your life harder later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made favicon out of sound waves image as the logo isn't really fit for that use, can change back if needed Also I changed articles in recommend and categories sections into links. Texts scale alongside the images because I thought it might make sense in the context of this page. If that's not right for the task, I'll restructure that as well! 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 🚀
DEMO LINK