Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only mobile version #2596

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

kate-prakofyeva
Copy link

DEMO LINK

I'm submitting the completed version for mobile devices for review. Thank you

Copy link

@mvjl000 mvjl000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mobile version looks very good.
The only thing I would like you to change is to disable the textarea resize (also make sure that all corners are rounded)

@kate-prakofyeva
Copy link
Author

The mobile version looks very good. The only thing I would like you to change is to disable the textarea resize (also make sure that all corners are rounded)
image

image
image
All fields have border-radius, I checked it, thanks

Copy link

@mvjl000 mvjl000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to see it finished! 😺

@kate-prakofyeva
Copy link
Author

Can't wait to see it finished! 😺

Can't wait to see it finished! 😺

I have a question, is it normal that I have almost everything sizes, colors ... in variables?

@kate-prakofyeva
Copy link
Author

Finished landing page, ready for review

Copy link

@mvjl000 mvjl000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Inputs state styles should be a bit different. The border should be gray on hover, and when they're focused, they should have orange border (border/outline),
  • Buttons on hover should be dark gray, they should be black when you press them (active),
  • The phone number inside the menu should also be a link

@kate-prakofyeva
Copy link
Author

  • Buttons on hover should be dark gray, they should be black when you press them (active),
    done
    image
    image
    image
    image
  • The phone number inside the menu should also be a link
    done
    image
  • Inputs state styles should be a bit different. The border should be gray on hover, and when they're focused, they should have orange border (border/outline),
    done
    image
    image
    image

Copy link

@mvjl000 mvjl000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants