Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Did the header and side menu #2600

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Did the header and side menu #2600

wants to merge 12 commits into from

Conversation

szymanski-marcin
Copy link

JoyCoffeeAddict
JoyCoffeeAddict suggested changes Oct 24, 2023
View reviewed changes
Copy link

@JoyCoffeeAddict JoyCoffeeAddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Center these images as in figma
    image
  2. change the background image on mobile to match the one from figma
    image
    image
  3. Horizontal padding of your title is too big (as above)
  4. You need to add a favicon

mvjl000
mvjl000 suggested changes Oct 25, 2023
View reviewed changes
Copy link

@mvjl000 mvjl000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Those icons on mobile are way too small
    Screenshot 2023-10-25 at 08 47 19

mbruhler
mbruhler suggested changes Oct 25, 2023
View reviewed changes
Copy link

@mbruhler mbruhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Contact Us section is a bit off
image

Also this section on larger devices looks off
image

JoyCoffeeAddict
JoyCoffeeAddict approved these changes Oct 25, 2023
View reviewed changes
Copy link

@JoyCoffeeAddict JoyCoffeeAddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, perfectly done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyCoffeeAddict JoyCoffeeAddict JoyCoffeeAddict approved these changes

@mvjl000 mvjl000 Awaiting requested review from mvjl000

@mbruhler mbruhler Awaiting requested review from mbruhler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szymanski-marcin @mbruhler @mvjl000 @JoyCoffeeAddict