develop #2601
develop #2601
Conversation
There was a problem hiding this comment.
- Paddings in the navigation are not the same as in the figma
- Phone icon on hover does not work
- Smooth scrolling is not working
- Wrong font-family here
- Hovering images does not work
- Some styling mistake with a button
- Form validation as described in the checklist
There was a problem hiding this comment.
Hi,
On mobile menu close button is in bad position
On mobile, Explore button is very small
On mobile, grid items are badly positioned
On desktop, logo is blurry and logo items are badly positioned
Your contact form has extra outline which is not compliant with figma mockup
There was a problem hiding this comment.
- form: send button has default borders (remove it), form submit shouldn't reload the page, simply clear the form values, I would disable resize for the textarea,
- Open menu icon should have the same size as the phone icon (e.g. on the desktop it is way to small),
- Open/Close menu button should be in the exact same position,
- On the tablet resolution, the "phone" text shouldn't be higher that the input
src/styles/blocks/details.scss
Outdated
| width: 276px; | ||
| &:hover { | ||
| cursor: pointer; | ||
| transition: box-shadow 0.3s; |
There was a problem hiding this comment.
The transitions mustn't be inside a hover. That's why your transitions are not smoothly going back to initial styles when you stop hovering them. Is should be moved up.
There was a problem hiding this comment.
To be clear - you should do so for all transitions in order to have them nicely 'animated'
There was a problem hiding this comment.
I want you to do something about your hover effects. As I said noticed in the previous review, you are applying transition inside of hover block. It has to be outside of it in order to have smooth 'exit' animation.
Speaking of hover effects, I would like you to prevent the images (for example from 'compare bike') from overlapping on text underneath them.
https://michal-reszka.github.io/layout_miami/