-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4546
base: master
Are you sure you want to change the base?
add task solution #4546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the pull request! 🎉 The issues noted are minor and don't impact the core functionality. Consider the feedback for future improvements. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
/> | ||
<img | ||
src="/src/images/Search.svg" | ||
alt="search image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alt attribute should describe the image content. Instead of 'search image', consider using a more descriptive text like 'search icon'.
|
||
<img | ||
src="/src/images/Search.svg" | ||
alt="search image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alt attribute should describe the image content. Instead of 'search image', consider using a more descriptive text like 'search icon'.
|
||
@font-face { | ||
font-family: Avenir; | ||
src: url(/src/fonts/Avenir-Book.ttf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's recommended to provide a fallback font in case the custom font fails to load. Consider adding a generic font family as a fallback.
|
||
@font-face { | ||
font-family: Avenir; | ||
src: url(/src/fonts/Avenir-Heavy.ttf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's recommended to provide a fallback font in case the custom font fails to load. Consider adding a generic font family as a fallback.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️