Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first try - search bar #4553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

first try - search bar #4553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://GrzegorzLasota.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://GrzegorzLasota.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
38 changes: 28 additions & 10 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,34 @@
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
<label
class="lab-first"
data-qa="big"
>
<img
alt="search-icon"
Comment on lines +24 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute should describe the image content. 'search-icon' is not descriptive enough. Consider using a more descriptive alt text, such as 'magnifying glass icon for search'.

src="images/Search.svg"
/>

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
</label>
<label
class="lab-second"
data-qa="small"
>
<img
alt="search-icon"
Comment on lines +39 to +40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute should describe the image content. 'search-icon' is not descriptive enough. Consider using a more descriptive alt text, such as 'magnifying glass icon for search'.

src="images/Search.svg"
/>

<input
type="text"
placeholder="Try “Los Angeles“"
/>
</label>
</body>
</html>
74 changes: 73 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,73 @@
/* add styles here */
@font-face {
font-family: Avenir;
src: url(/src/fonts/Avenir-Book.ttf) format('opentype') tech(color-COLRv1);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tech(color-COLRv1) part of the src property is not standard CSS. If you intended to use a specific technology or format, ensure it's supported by browsers or remove it.


body {
margin: 0;
padding: 20px;
font-weight: 300;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using only top or bottom padding to avoid potential margin collapse issues. The checklist suggests being consistent with margins and padding.

}

.lab-first img {
width: 19px;
height: 19px;
margin-left: 26px;
margin-right: 17px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using only margin-left or margin-right to avoid potential margin collapse issues. The checklist suggests being consistent with margins.

}

.lab-second img {
width: 11px;
height: 11px;
margin-left: 13px;
margin-right: 9px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using only margin-left or margin-right to avoid potential margin collapse issues. The checklist suggests being consistent with margins.

}

.lab-first {
width: 100%;
display: flex;
justify-content: center;
align-items: center;
border: 1px solid #4242426e;
height: 70px;
}

.lab-first:hover {
box-shadow: 12px 2px 10px #a1244a;
}

.lab-first input {
border: none;
width: 100%;
height: 98%;
}

.lab-second {
width: 100%;
display: flex;
justify-content: center;
align-items: center;
border: 1px solid #4242426e;
height: 42px;
margin: 20px auto 0;
}

.lab-second input {
border: none;
width: 100%;
height: 90%;
}

.lab-second:hover {
box-shadow: 12px 2px 10px #138392;
}

.lab-second input:focus {
box-shadow: 12px 2px 10px #138392;
outline: none;
}

.lab-first input:focus {
box-shadow: 12px 2px 10px #a1244a;
outline: none;
}
Loading