Solution #439
Solution #439
Conversation
There was a problem hiding this comment.
Great job on implementing the Bulls and Cows game! 🎉 The core functionality is working well, and you've done a fantastic job with the user input validation and bulls and cows calculation. Just a couple of minor tweaks needed: ensure the generated number is always 4 digits and doesn't start with 0, and convert userInput to a number before passing it to getBullsAndCows. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| rl.question('Enter your number: ', (userInput) => { | ||
| if (checkIsValidUserInput(userInput)) { | ||
| // eslint-disable-next-line no-console | ||
| console.log(getBullsAndCows(userInput, generatedNumber)); |
There was a problem hiding this comment.
The userInput is currently passed as a string to getBullsAndCows, which expects numeric inputs. Consider converting userInput to a number before passing it to the function.
| @@ -7,7 +7,13 @@ | |||
| * @return {number} A random 4-digit number | |||
| */ | |||
| function generateRandomNumber() { | |||
| /* Write your code here */ | |||
| const randomNumber = Math.floor(Math.random() * (10000 - 1) + 1); | |||
There was a problem hiding this comment.
The current logic can generate numbers with fewer than 4 digits and numbers starting with 0. Consider adjusting the range to ensure the generated number is a 4-digit number that does not start with 0.
| /* Write your code here */ | ||
| const randomNumber = Math.floor(Math.random() * (10000 - 1) + 1); | ||
|
|
||
| if (new Set(randomNumber.toString()).size !== 4) { |
There was a problem hiding this comment.
The check for duplicate digits is correct, but ensure that the generated number is always 4 digits long and does not start with 0.
No description provided.