-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1006
base: master
Are you sure you want to change the base?
Solution #1006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉 The code is well-structured and adheres to the task checklist requirements. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
from models import Actor | ||
|
||
|
||
class ActorManager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name 'ActorManager' is correctly in singular form, which aligns with the checklist requirement.
class ActorManager: | ||
def __init__(self) -> None: | ||
self._connection = sqlite3.connect("../cinema.sqlite") | ||
self.table_name = "actors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table name 'actors' is correctly in plural form, which aligns with the checklist requirement that if a database contains more than one object, it should be named in plural.
|
||
|
||
@dataclass | ||
class Actor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name 'Actor' is correctly in singular form, which adheres to the checklist requirement.
No description provided.