-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1011
base: master
Are you sure you want to change the base?
Solution #1011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the ActorManager
class and setting up the Actor
dataclass! 🎉 Your code meets all the core requirements and is well-structured. Although there are minor issues like spacing for readability and a typo in a last name, these do not impact the functionality of your code. Keep up the good work, and consider addressing these minor points for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Actor.objects = ActorManager() | ||
|
||
# Actor.objects.create(first_name="Emma", last_name="Watson") | ||
# Actor.objects.create(first_name="Daniel", last_name="Radclife") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the last name 'Radclife'. It should be 'Radcliffe'.
app/managers.py
Outdated
|
||
class ActorManager: | ||
def __init__(self): | ||
self._connection =sqlite3.connect('cinema.sqlite') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing space between '=' and 'sqlite3.connect'. It should be self._connection = sqlite3.connect('cinema.sqlite')
for better readability.
No description provided.