Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #602

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #602

wants to merge 3 commits into from

Conversation

SerhiyDema
Copy link

attempt 01

vsmutok
vsmutok suggested changes Oct 7, 2024
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated
Comment on lines 58 to 68
if not issubclass(self.limitation_class, SlideLimitationValidator):
return False
validate_instance = self.limitation_class()

validate_instance.age = visitor.age
validate_instance.height = visitor.height
validate_instance.weight = visitor.weight

return bool(validate_instance.age
and validate_instance.height
and validate_instance.weight)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use try ... except here

SerhiyDema and others added 2 commits October 7, 2024 13:22
@SerhiyDema @vsmutok
Update app/main.py
aff64ce 
thanks, undesrtand

Co-authored-by: Vasyl Smutok <vasyl.smutok@gmail.com>
@SerhiyDema
Solution
c5bf039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasylhnatiuk vasylhnatiuk vasylhnatiuk approved these changes

@vsmutok vsmutok Awaiting requested review from vsmutok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SerhiyDema @vsmutok @vasylhnatiuk