-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #615
base: master
Are you sure you want to change the base?
solution #615
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,96 @@ | ||
from __future__ import annotations | ||
from abc import ABC | ||
|
||
|
||
class IntegerRange: | ||
pass | ||
def __init__( | ||
self, | ||
min_amount: int, | ||
max_amount: int | ||
) -> None: | ||
self.min_amount = min_amount | ||
self.max_amount = max_amount | ||
|
||
def __set_name__( | ||
self, | ||
owner: SlideLimitationValidator, | ||
name: str | ||
) -> None: | ||
self.protected_name = "_" + name | ||
|
||
def __get__( | ||
self, | ||
instance: SlideLimitationValidator, | ||
owner: SlideLimitationValidator | ||
) -> int: | ||
return getattr(instance, self.protected_name) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same issue here with the |
||
|
||
def __set__( | ||
self, | ||
instance: SlideLimitationValidator, | ||
value: int | ||
) -> None: | ||
if self.min_amount <= value <= self.max_amount: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a code quality issue. You should check for invalid input and throw an exception if the input is invalid. Currently, if the value is not within the specified range, the attribute is not set at all, which could lead to confusing behavior. |
||
setattr(instance, self.protected_name, value) | ||
|
||
|
||
class Visitor: | ||
pass | ||
def __init__(self, name: str, age: int, weight: int, height: int) -> None: | ||
self.name = name | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class SlideLimitationValidator(ABC): | ||
pass | ||
def __init__( | ||
self, | ||
age: int, | ||
weight: int, | ||
height: int | ||
) -> None: | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
class ChildrenSlideLimitationValidator( | ||
SlideLimitationValidator | ||
): | ||
age = IntegerRange(4, 14) | ||
height = IntegerRange(80, 120) | ||
weight = IntegerRange(20, 50) | ||
|
||
def __init__(self, age: int, weight: int, height: int) -> None: | ||
super().__init__(age, weight, height) | ||
|
||
class AdultSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
|
||
class AdultSlideLimitationValidator( | ||
SlideLimitationValidator | ||
): | ||
age = IntegerRange(14, 60) | ||
height = IntegerRange(120, 220) | ||
weight = IntegerRange(50, 120) | ||
|
||
def __init__(self, age: int, weight: int, height: int) -> None: | ||
super().__init__(age, weight, height) | ||
|
||
|
||
class Slide: | ||
pass | ||
def __init__( | ||
self, | ||
name: str, | ||
limitation_class: SlideLimitationValidator | ||
) -> None: | ||
self.name = name | ||
self.limitation_class = limitation_class | ||
|
||
def can_access(self, visitor: Visitor) -> Visitor | None: | ||
result = (self.limitation_class( | ||
visitor.age, | ||
visitor.weight, | ||
visitor.height | ||
)) | ||
if len(result.__dict__) == 3: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a code quality issue. Checking the length of the |
||
return True | ||
return False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a bug. Your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a type hinting issue here. The
owner
argument in the__set_name__
method is expected to be ofSlideLimitationValidator
type, but you are passingself
which is ofIntegerRange
type. Consider reviewing your type hints.