Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 79 additions & 8 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,96 @@
from __future__ import annotations
from abc import ABC


class IntegerRange:
pass
def __init__(
self,
min_amount: int,
max_amount: int
) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(
self,
owner: SlideLimitationValidator,
name: str
) -> None:
Comment on lines +14 to +18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a type hinting issue here. The owner argument in the __set_name__ method is expected to be of SlideLimitationValidator type, but you are passing self which is of IntegerRange type. Consider reviewing your type hints.

self.protected_name = "_" + name

def __get__(
self,
instance: SlideLimitationValidator,
owner: SlideLimitationValidator
) -> int:
return getattr(instance, self.protected_name)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here with the instance argument. It's type hinted as SlideLimitationValidator but self of IntegerRange type is being passed.


def __set__(
self,
instance: SlideLimitationValidator,
value: int
) -> None:
if self.min_amount <= value <= self.max_amount:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a code quality issue. You should check for invalid input and throw an exception if the input is invalid. Currently, if the value is not within the specified range, the attribute is not set at all, which could lead to confusing behavior.

setattr(instance, self.protected_name, value)


class Visitor:
pass
def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
def __init__(
self,
age: int,
weight: int,
height: int
) -> None:
self.age = age
self.weight = weight
self.height = height


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
class ChildrenSlideLimitationValidator(
SlideLimitationValidator
):
age = IntegerRange(4, 14)
height = IntegerRange(80, 120)
weight = IntegerRange(20, 50)

def __init__(self, age: int, weight: int, height: int) -> None:
super().__init__(age, weight, height)

class AdultSlideLimitationValidator(SlideLimitationValidator):
pass

class AdultSlideLimitationValidator(
SlideLimitationValidator
):
age = IntegerRange(14, 60)
height = IntegerRange(120, 220)
weight = IntegerRange(50, 120)

def __init__(self, age: int, weight: int, height: int) -> None:
super().__init__(age, weight, height)


class Slide:
pass
def __init__(
self,
name: str,
limitation_class: SlideLimitationValidator
) -> None:
self.name = name
self.limitation_class = limitation_class

def can_access(self, visitor: Visitor) -> Visitor | None:
result = (self.limitation_class(
visitor.age,
visitor.weight,
visitor.height
))
if len(result.__dict__) == 3:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a code quality issue. Checking the length of the __dict__ attribute to determine if the object is valid is not a good practice. It might be better to define a method in the SlideLimitationValidator class to check if the object is valid, and call that method here.

return True
return False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug. Your can_access method is supposed to return a Visitor object or None, but it actually returns a boolean. You should return the visitor if the conditions are met, or None otherwise.

Loading