created system of determines visitors #618
Conversation
There was a problem hiding this comment.
Great job on the pull request! 🎉 While there are a few areas where you can improve, such as ensuring proper validation with the limitation_class and adding informative messages to exceptions, these are minor and don't impact the core functionality. Keep up the good work and consider these suggestions for future improvements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| def __set__(self, instance: type, value: int) -> None: | ||
| if not isinstance(value, int): | ||
| raise TypeError |
There was a problem hiding this comment.
This line raises a TypeError without a message. It's a good practice to provide a message to make debugging easier.
| if not isinstance(value, int): | ||
| raise TypeError | ||
| if not (self.min_amount <= value <= self.max_amount): | ||
| raise ValueError |
There was a problem hiding this comment.
This line raises a ValueError without a message. Consider adding a message to provide more context about the error.
|
|
||
| def can_access(self, visitor: Visitor) -> bool: | ||
| try: | ||
| self.limitation_class(visitor.age, visitor.weight, visitor.height) |
There was a problem hiding this comment.
The limitation_class is being instantiated with visitor attributes, but it seems like the intention is to validate the visitor against the slide's limitations. Ensure that the limitation_class is used correctly to validate the visitor.
No description provided.