Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed #1653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 61 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,62 @@
class Distance:
# Write your code here
pass
def __init__(self, km: float) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: any) -> any:
if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: any) -> any:
if isinstance(other, Distance):
self.km += other.km
elif isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: any) -> any:
return Distance(self.km * other)
Comment on lines +24 to +25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the __mul__ method, you should check if other is an instance of int or float before performing the multiplication. This ensures that the operation is valid and prevents potential errors when multiplying with unsupported types.


def __truediv__(self, other: any) -> any:
if isinstance(other, (int, float)) and other != 0:
return Distance(round(self.km / other, 2))
elif other == 0:
raise ZeroDivisionError("Division by zero is not allowed")
return NotImplemented

def __lt__(self, other: any) -> bool:
if isinstance(other, (int, float)):
return self.km < other
elif isinstance(other, Distance):
return self.km < other.km
Comment on lines +34 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __lt__ method should return NotImplemented if other is not a Distance, int, or float. This is important for proper operation with other types and ensures that Python can handle the comparison correctly.


def __gt__(self, other: any) -> bool:
if isinstance(other, (int, float)):
return self.km > other
elif isinstance(other, Distance):
return self.km > other.km
Comment on lines +40 to +44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to __lt__, the __gt__ method should return NotImplemented if other is not a Distance, int, or float. This allows Python to try other methods for comparison if the types are not compatible.


def __eq__(self, other: any) -> bool:
if isinstance(other, (int, float)):
return self.km == other
elif isinstance(other, Distance):
return self.km == other.km
Comment on lines +46 to +50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the __eq__ method, consider returning NotImplemented if other is not a Distance, int, or float. This is a good practice to ensure that equality checks with unsupported types are handled gracefully.


def __le__(self, other: any) -> bool:
if isinstance(other, (int, float)):
return self.km <= other
elif isinstance(other, Distance):
return self.km <= other.km
Comment on lines +52 to +56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __le__ method should also return NotImplemented for unsupported types, similar to the other comparison methods.


def __ge__(self, other: any) -> bool:
if isinstance(other, (int, float)):
return self.km >= other
elif isinstance(other, Distance):
return self.km >= other.km
Comment on lines +58 to +62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the __ge__ method returns NotImplemented if other is not a Distance, int, or float, to maintain consistency with the other comparison methods.

Loading