Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor Animal class and its subclasses #1204

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,50 @@
# write your code here
class Animal:
def __init__(
self, name: str, appetite: int, is_hungry: bool = True
) -> None:
self.name = name
self.appetite = appetite
self.is_hungry = is_hungry

def print_name(self) -> None:
print(f"Hello, I'm {self.name}")

def feed(self) -> None:
if self.is_hungry:
print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
return 0


class Cat(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=3, is_hungry=is_hungry)

def catch_mouse(self) -> None:
print("The hunt began!")


class Dog(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=7, is_hungry=is_hungry)

def bring_slippers(self) -> None:
print("The slippers delivered!")


def feed_animals(animals: list) -> None:
total_food = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def feed_animals(animals: list) -> None:
def feed_animals(animals: list[Animal]) -> None:

for animal in animals:
total_food += animal.feed()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use list comprehension

animal.feed()
return total_food

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return total_food
return sum(animal.feed() for animal in animals)


elephant = Animal("Elephant", 100)
rat = Animal("Rat", 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this code

lion = Animal("Lion", 25)
cat = Cat("Cat", False)

food_points = feed_animals([elephant, rat, lion, cat])
print("food points:", food_points)
Loading