created animals classes #561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Jul 11, 2023
app/main.py
Outdated
Comment on lines
17
to
18
| points = self.appetite | ||
| self.appetite = 0 |
There was a problem hiding this comment.
Not said that we need to change it to 0
app/main.py
Outdated
| print(f"Hello, I'm {self.name}") | ||
|
|
||
| def feed(self) -> int: | ||
| if self.appetite and self.is_hungry: |
There was a problem hiding this comment.
Suggested change
| if self.appetite and self.is_hungry: | |
| if self.is_hungry: |
Not need to check by self.appetite
app/main.py
Outdated
Comment on lines
24
to
25
| def __init__(self, name: str, is_hungry: bool = True, | ||
| appetite: int = 3) -> None: |
There was a problem hiding this comment.
Suggested change
| def __init__(self, name: str, is_hungry: bool = True, | |
| appetite: int = 3) -> None: | |
| def __init__( | |
| self, name: str, appetite: int = 3, is_hungry: bool = True | |
| ) -> None: |
No need to change order of params
app/main.py
Outdated
Comment on lines
36
to
37
| def __init__(self, name: str, is_hungry: bool = True, | ||
| appetite: int = 7) -> None: |
There was a problem hiding this comment.
Suggested change
| def __init__(self, name: str, is_hungry: bool = True, | |
| appetite: int = 7) -> None: | |
| def __init__( | |
| self, name: str, appetite: int = 7, is_hungry: bool = True | |
| ) -> None: |
vasylhnatiuk
suggested changes
Jul 11, 2023
|
|
||
|
|
||
| class Cat(Animal): | ||
| def __init__(self, name: str, |
There was a problem hiding this comment.
init must get only 2 arguments without appetite, rewrite it
vasylhnatiuk
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.