'Solution' #564
Open
'Solution' #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdan-Salamakha
suggested changes
Jul 14, 2023
app/main.py
Outdated
| print(f"Eating {self.appetite} food points...") | ||
| self.is_hungry = False | ||
| return self.appetite | ||
| else: |
app/main.py
Outdated
| print("The slippers delivered!") | ||
|
|
||
|
|
||
| def feed_animals(list_animals: list) -> int: |
There was a problem hiding this comment.
add additional typehint for list inner objects like list[YOUR_VALUE_TYPE]
for example: list that contains string elements has typehint list[str]
app/main.py
Outdated
Comment on lines
45
to
51
| sum_result = 0 | ||
| for elem in list_animals: | ||
| if elem.is_hungry: | ||
| sum_result += elem.appetite | ||
| elem.feed() | ||
|
|
||
| return sum_result |
There was a problem hiding this comment.
use generator expression to do it
Bohdan-Salamakha
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.