Solution #574
Open
Solution #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Jul 26, 2023
app/main.py
Outdated
Comment on lines
20
to
21
| else: | ||
| return 0 |
There was a problem hiding this comment.
else: is not needed
Suggested change
| else: | |
| return 0 | |
| return 0 |
app/main.py
Outdated
Comment on lines
26
to
28
| super().__init__(name, is_hungry) | ||
| self.is_hungry = is_hungry | ||
| self.appetite = 3 |
There was a problem hiding this comment.
Suggested change
| super().__init__(name, is_hungry) | |
| self.is_hungry = is_hungry | |
| self.appetite = 3 | |
| super().__init__(name, 3, is_hungry) |
Just pass the parameters here. Fix inside dog
app/main.py
Outdated
Comment on lines
47
to
50
| count = 0 | ||
| for animal in animals: | ||
| count += Animal.feed(animal) | ||
| return count |
app/main.py
Outdated
| def feed_animals(animals: list) -> int: | ||
| count = 0 | ||
| for animal in animals: | ||
| count += Animal.feed(animal) |
app/main.py
Outdated
| print("The slippers delivered!") | ||
|
|
||
|
|
||
| def feed_animals(animals: list) -> int: |
There was a problem hiding this comment.
list of what? Provide inner type
ArsenPidhoretskyi
suggested changes
Jul 26, 2023
app/main.py
Outdated
| print("The slippers delivered!") | ||
|
|
||
|
|
||
| def feed_animals(animals: list[Animal | Cat | Dog]) -> int: |
There was a problem hiding this comment.
Suggested change
| def feed_animals(animals: list[Animal | Cat | Dog]) -> int: | |
| def feed_animals(animals: list[Animal]) -> int: |
Cat and Dog is inherit from Animal that means all will be work okay
vasylhnatiuk
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.