implement formatter functions to py-linter-formatter #1906
Conversation
There was a problem hiding this comment.
Your code is well-structured and meets all the task requirements! 🎉 While there's a minor suggestion to refactor the error formatting logic to reduce redundancy, it doesn't impact the functionality. Keep up the great work and consider this refactoring for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| "errors": | ||
| [ | ||
| { | ||
| "line": err_single_file["line_number"], | ||
| "column": err_single_file["column_number"], | ||
| "message": err_single_file["text"], | ||
| "name": err_single_file["code"], | ||
| "source": "flake8" | ||
| } for err_single_file in errors |
There was a problem hiding this comment.
The logic for formatting errors in format_single_linter_file is similar to the one in format_linter_report. Consider refactoring this logic into a separate function to avoid redundancy and improve maintainability.
| "errors": [ | ||
| { | ||
| "line": single_error["line_number"], | ||
| "column": single_error["column_number"], | ||
| "message": single_error["text"], | ||
| "name": single_error["code"], | ||
| "source": "flake8" | ||
| } for single_error in file_errors |
There was a problem hiding this comment.
The error formatting logic here is repeated from format_single_linter_file. It would be beneficial to extract this into a helper function to reduce code duplication.
No description provided.