Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1213

wants to merge 3 commits into from

Conversation

vmyronets
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your code! There are a few improvements that could be made, such as using parentheses when importing multiple classes, simplifying your if statements, and using type hinting. There's also a bug where you're trying to compare a date with a dictionary. Don't worry, with a bit more polishing your code will be top-notch! Keep going! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job so far! 👍 However, I would suggest making some improvements to your error messages to make them more descriptive. Also, there are a few code efficiency suggestions that you might want to consider. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/main.py Show resolved Hide resolved
app/main.py Show resolved Hide resolved
app/main.py Show resolved Hide resolved
app/main.py Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the code! You've done well in handling errors and checking conditions. However, there are a few issues that need to be addressed. Please review the comments regarding the use of double quotes inside a string and the addition of docstrings to your classes and methods. These changes will improve the readability and maintainability of your code. Keep up the good work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants