Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1225

wants to merge 3 commits into from

Conversation

Krasul1a
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few critical issues that need to be addressed before we can approve the Pull Request. The __init__ method's return type should be corrected to None, and the visit_cafe method should return a string as intended. Additionally, ensure that the expiration_date key is checked before accessing it to prevent potential errors. Once these are fixed, your code will be in great shape! Keep up the good work and don't hesitate to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Outdated Show resolved Hide resolved
app/cafe.py Show resolved Hide resolved
app/main.py Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the core functionality! 🎉 There are a few areas for improvement, such as ensuring 'expiration_date' is a valid date object and enhancing exception handling clarity. These adjustments will help you avoid potential runtime errors and improve code readability. Keep up the good work and continue refining your skills!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/cafe.py Outdated Show resolved Hide resolved
app/main.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants