Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1662

wants to merge 1 commit into from

Conversation

IllyaKovaliuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Person class and the create_person_list function! 🎉 Your code meets the task requirements and constraints effectively. While there is a minor suggestion to use dict.get() for accessing dictionary values to prevent potential KeyError, this doesn't impact the core functionality. Keep up the good work, and consider this improvement for future projects to enhance robustness! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +16 to +19
if "wife" in person and person["wife"]:
Person.people[name].wife = Person.people[person["wife"]]
elif "husband" in person and person["husband"]:
Person.people[name].husband = Person.people[person["husband"]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the spouse (wife or husband) is already present in the Person.people dictionary. If the spouse is not found, this will raise a KeyError. Consider adding a check to ensure the spouse exists in the dictionary before assigning it, or handle the exception gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants