Solution #765
Open
Solution #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyakoziar
approved these changes
Oct 3, 2023
fsocie7y
suggested changes
Oct 3, 2023
app/main.py
Outdated
|
|
||
| # Adding husband and wife for people | ||
| for person in people: | ||
| if person.get("husband") is not None: |
There was a problem hiding this comment.
Is not None` is redundant here, since in your case if statement will be True if key exists
app/main.py
Outdated
| husband_obj = Person.people[person["husband"]] | ||
| person_obj.husband = husband_obj | ||
|
|
||
| if person.get("wife") is not None: |
app/main.py
Outdated
| pass | ||
| person_list: [Person] = [] | ||
|
|
||
| for person in people: |
There was a problem hiding this comment.
Try to rewrite in one line. Hint: list comprehension 🤫
fsocie7y
approved these changes
Oct 4, 2023
| for person in people | ||
| ] | ||
|
|
||
| # Adding husband and wife for people |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.