Solution #778
Open
Solution #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I think my implementation of the task is not good. Can someone help to implement this task in a more convenient way? |
|
Now It may be better) |
app/main.py
Outdated
| def __init__(self, name: str, age: int) -> None: | ||
| self.name = name | ||
| self.age = age | ||
| Person.people[name] = self |
There was a problem hiding this comment.
Suggested change
| Person.people[name] = self | |
| self.pople[name] = self |
maybe it will be better
Andrii-Silenko
approved these changes
Oct 4, 2023
fsocie7y
suggested changes
Oct 4, 2023
app/main.py
Outdated
| for index, person in enumerate(people_data): | ||
| wife = person.get("wife") | ||
| husband = person.get("husband") | ||
| if wife is not None: |
There was a problem hiding this comment.
Is not None is redundant here, since in your case if statement will be True if key exists
app/main.py
Outdated
| husband = person.get("husband") | ||
| if wife is not None: | ||
| person_list[index].wife = Person.people.get(wife) | ||
| if husband is not None: |
app/main.py
Outdated
| def create_person_list(people_data: dict) -> list[Person]: | ||
| person_list = [] | ||
|
|
||
| for person_item in people_data: |
There was a problem hiding this comment.
Try to rewrite in one line. Hint: list comprehension 🤫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.