Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #912

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 114 additions & 58 deletions db/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -1,58 +1,114 @@
# Generated by Django 4.0.2 on 2022-06-15 12:37

from django.db import migrations, models
import django.db.models.deletion


class Migration(migrations.Migration):

initial = True

dependencies = [
]

operations = [
migrations.CreateModel(
name='Actor',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('first_name', models.CharField(max_length=255)),
('last_name', models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name='CinemaHall',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255)),
('rows', models.IntegerField()),
('seats_in_row', models.IntegerField()),
],
),
migrations.CreateModel(
name='Genre',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255, unique=True)),
],
),
migrations.CreateModel(
name='Movie',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('title', models.CharField(max_length=255)),
('description', models.TextField()),
('actors', models.ManyToManyField(to='db.Actor')),
('genres', models.ManyToManyField(to='db.Genre')),
],
),
migrations.CreateModel(
name='MovieSession',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('show_time', models.DateTimeField()),
('cinema_hall', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.cinemahall')),
('movie', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.movie')),
],
),
]
# Generated by Django 4.0.2 on 2024-10-15 13:43

from django.conf import settings
import django.contrib.auth.models
import django.contrib.auth.validators
from django.db import migrations, models
import django.db.models.deletion
import django.utils.timezone


class Migration(migrations.Migration):

initial = True

dependencies = [
('auth', '0012_alter_user_first_name_max_length'),
]

operations = [
migrations.CreateModel(
name='User',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('password', models.CharField(max_length=128, verbose_name='password')),
('last_login', models.DateTimeField(blank=True, null=True, verbose_name='last login')),
('is_superuser', models.BooleanField(default=False, help_text='Designates that this user has all permissions without explicitly assigning them.', verbose_name='superuser status')),
('username', models.CharField(error_messages={'unique': 'A user with that username already exists.'}, help_text='Required. 150 characters or fewer. Letters, digits and @/./+/-/_ only.', max_length=150, unique=True, validators=[django.contrib.auth.validators.UnicodeUsernameValidator()], verbose_name='username')),
('first_name', models.CharField(blank=True, max_length=150, verbose_name='first name')),
('last_name', models.CharField(blank=True, max_length=150, verbose_name='last name')),
('email', models.EmailField(blank=True, max_length=254, verbose_name='email address')),
('is_staff', models.BooleanField(default=False, help_text='Designates whether the user can log into this admin site.', verbose_name='staff status')),
('is_active', models.BooleanField(default=True, help_text='Designates whether this user should be treated as active. Unselect this instead of deleting accounts.', verbose_name='active')),
('date_joined', models.DateTimeField(default=django.utils.timezone.now, verbose_name='date joined')),
('groups', models.ManyToManyField(blank=True, help_text='The groups this user belongs to. A user will get all permissions granted to each of their groups.', related_name='user_set', related_query_name='user', to='auth.Group', verbose_name='groups')),
('user_permissions', models.ManyToManyField(blank=True, help_text='Specific permissions for this user.', related_name='user_set', related_query_name='user', to='auth.Permission', verbose_name='user permissions')),
],
options={
'verbose_name': 'user',
'verbose_name_plural': 'users',
'abstract': False,
},
managers=[
('objects', django.contrib.auth.models.UserManager()),
],
),
migrations.CreateModel(
name='Actor',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('first_name', models.CharField(max_length=255)),
('last_name', models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name='CinemaHall',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255)),
('rows', models.IntegerField()),
('seats_in_row', models.IntegerField()),
],
),
migrations.CreateModel(
name='Genre',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255, unique=True)),
],
),
migrations.CreateModel(
name='Movie',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('title', models.CharField(db_index=True, max_length=255)),
('description', models.TextField()),
('actors', models.ManyToManyField(related_name='movies', to='db.Actor')),
('genres', models.ManyToManyField(related_name='movies', to='db.Genre')),
],
),
migrations.CreateModel(
name='MovieSession',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('show_time', models.DateTimeField()),
('cinema_hall', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.cinemahall')),
('movie', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.movie')),
],
),
migrations.CreateModel(
name='Order',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('created_at', models.DateTimeField(auto_now_add=True)),
('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL)),
],
options={
'ordering': ['-created_at'],
},
),
migrations.CreateModel(
name='Ticket',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('row', models.IntegerField()),
('seat', models.IntegerField()),
('movie_session', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='tickets', to='db.moviesession')),
('order', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='order_tickets', to='db.order')),
],
),
migrations.AddConstraint(
model_name='ticket',
constraint=models.UniqueConstraint(fields=('movie_session', 'row', 'seat'), name='unique_movie_session'),
),
]
71 changes: 70 additions & 1 deletion db/models.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from django.core.exceptions import ValidationError
from django.db import models
from django.contrib.auth.models import AbstractUser
from django.db.models import UniqueConstraint
from django.conf import settings


class Genre(models.Model):
Expand All @@ -17,7 +21,7 @@ def __str__(self) -> str:


class Movie(models.Model):
title = models.CharField(max_length=255)
title = models.CharField(max_length=255, db_index=True)
description = models.TextField()
actors = models.ManyToManyField(to=Actor, related_name="movies")
genres = models.ManyToManyField(to=Genre, related_name="movies")
Expand Down Expand Up @@ -50,3 +54,68 @@ class MovieSession(models.Model):

def __str__(self) -> str:
return f"{self.movie.title} {str(self.show_time)}"


class Order(models.Model):
created_at = models.DateTimeField(auto_now_add=True)
user = models.ForeignKey(settings.AUTH_USER_MODEL,
Hennadii29 marked this conversation as resolved.
Show resolved Hide resolved
on_delete=models.CASCADE
)

class Meta:
ordering = ["-created_at"]
Hennadii29 marked this conversation as resolved.
Show resolved Hide resolved

def __str__(self) -> str:
return f"{self.created_at}"


class Ticket(models.Model):
movie_session = models.ForeignKey(
MovieSession,
on_delete=models.CASCADE,
related_name="tickets"
)

order = models.ForeignKey(
Order,
on_delete=models.CASCADE,
related_name="order_tickets"
)
row = models.IntegerField()
seat = models.IntegerField()

def clean(self) -> None:
errors = {}

if not (1 <= self.row <= self.movie_session.cinema_hall.rows):
errors["row"] = [
f"row number must be in available range: "
f"(1, rows): (1, {self.movie_session.cinema_hall.rows})"
]
if not (1 <= self.seat <= self.movie_session.cinema_hall.seats_in_row):
errors["seat"] = [
f"seat number must be in available range: "
f"(1, seats_in_row): "
f"(1, {self.movie_session.cinema_hall.seats_in_row})"
]
if errors:
raise ValidationError(errors)

def save(self, *args, **kwargs) -> None:
self.full_clean()
super().save(*args, **kwargs)

class Meta:
constraints = [
UniqueConstraint(fields=["movie_session", "row", "seat"],
name="unique_movie_session"),
]

def __str__(self) -> str:
return (f"{self.movie_session.movie.title} "
f"{self.movie_session.show_time}"
f" (row: {self.row}, seat: {self.seat})")


class User(AbstractUser):
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using get_user_model() method instead of directly referring to the User model. This is a good practice in Django as it allows for flexibility in case you decide to use a custom user model in the future.

3 changes: 2 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ flake8-quotes==3.3.1
flake8-variables-names==0.0.5
pep8-naming==0.13.2
pytest==7.1.3
pytest-django==4.5.2
pytest-django==4.5.2
django-extensions==3.2.3
7 changes: 6 additions & 1 deletion services/movie.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from django.db.models import QuerySet

from django.db import transaction
from db.models import Movie


def get_movies(
genres_ids: list[int] = None,
actors_ids: list[int] = None,
title: str = None,
) -> QuerySet:
queryset = Movie.objects.all()

Expand All @@ -15,13 +16,17 @@ def get_movies(
if actors_ids:
queryset = queryset.filter(actors__id__in=actors_ids)

if title:
queryset = queryset.filter(title__icontains=title)

return queryset


def get_movie_by_id(movie_id: int) -> Movie:
return Movie.objects.get(id=movie_id)


@transaction.atomic
def create_movie(
movie_title: str,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the code style guide, you should use double quotes instead of single quotes. It would be better to use double quotes for string values to keep the code style consistent.

movie_description: str,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment applies here as well, please use double quotes for string values.

Expand Down
10 changes: 9 additions & 1 deletion services/movie_session.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from django.db.models import QuerySet

from db.models import MovieSession


Expand Down Expand Up @@ -42,3 +41,12 @@ def update_movie_session(

def delete_movie_session_by_id(session_id: int) -> None:
MovieSession.objects.get(id=session_id).delete()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are using get() method which will raise a DoesNotExist exception if no object found. It would be better to use filter() method along with delete() which will not raise an exception if no object found.



def get_taken_seats(movie_session_id: int) -> list[dict]:
movie_session = get_movie_session_by_id(movie_session_id)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the checklist, it is recommended to use get_user_model() instead of User. Although you have not used User here, it's important to keep this in mind in other parts of your code as well.

seats_rows = [
{"row": ticket.row, "seat": ticket.seat}
for ticket in movie_session.tickets.all()
]
return seats_rows
34 changes: 34 additions & 0 deletions services/order.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
from django.contrib.auth import get_user_model
from django.db.models import QuerySet
from django.db import transaction


from db.models import Ticket, Order


@transaction.atomic
def create_order(tickets: list[dict],
username: str,
date: str = None
) -> QuerySet:
Hennadii29 marked this conversation as resolved.
Show resolved Hide resolved
user = get_user_model().objects.get(username=username)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Style: You are using single quotes in get(username=username). It's better to use double quotes in the whole project for consistency. Replace it with get(username=username).

order = Order.objects.create(user=user)

if date:
order.created_at = date

for ticket in tickets:
Ticket.objects.create(order=order,
movie_session_id=ticket["movie_session"],
row=ticket["row"],
seat=ticket["seat"]
)
order.save()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't Repeat Yourself: You are calling the save() method even if the date is not provided. It's better to call save() only if the date is provided, to avoid unnecessary database operations. You can use the update_fields argument of the save() method to save only the created_at field. Like this:

python
if date:
order.created_at = date
order.save(update_fields=['created_at'])

return order


def get_orders(username: str = None) -> QuerySet:
Hennadii29 marked this conversation as resolved.
Show resolved Hide resolved
orders = Order.objects.all()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Style: You are using single quotes in Order.objects.all(). It's better to use double quotes in the whole project for consistency. Replace it with Order.objects.all().

if username:
return orders.filter(user__username=username)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Style: You are using single quotes in filter(user__username=username). It's better to use double quotes in the whole project for consistency. Replace it with filter(user__username=username).

return orders
Loading
Loading