Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #912
base: master
Are you sure you want to change the base?
Solution #912
Changes from all commits
276ba60
49e7554
9f027e0
22848f4
0ba9dd4
a389480
cecd8ee
a6ebb97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using
get_user_model()
method instead of directly referring to theUser
model. This is a good practice in Django as it allows for flexibility in case you decide to use a custom user model in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the code style guide, you should use double quotes instead of single quotes. It would be better to use double quotes for string values to keep the code style consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same comment applies here as well, please use double quotes for string values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you are using
get()
method which will raise aDoesNotExist
exception if no object found. It would be better to usefilter()
method along withdelete()
which will not raise an exception if no object found.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the checklist, it is recommended to use
get_user_model()
instead ofUser
. Although you have not usedUser
here, it's important to keep this in mind in other parts of your code as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Style: You are using single quotes in
get(username=username)
. It's better to use double quotes in the whole project for consistency. Replace it withget(username=username)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't Repeat Yourself: You are calling the
save()
method even if thedate
is not provided. It's better to callsave()
only if thedate
is provided, to avoid unnecessary database operations. You can use theupdate_fields
argument of thesave()
method to save only thecreated_at
field. Like this:python
if date:
order.created_at = date
order.save(update_fields=['created_at'])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Style: You are using single quotes in
Order.objects.all()
. It's better to use double quotes in the whole project for consistency. Replace it withOrder.objects.all()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Style: You are using single quotes in
filter(user__username=username)
. It's better to use double quotes in the whole project for consistency. Replace it withfilter(user__username=username)
.