Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #916

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# Generated by Django 4.0.2 on 2024-10-20 22:13

from django.conf import settings
import django.contrib.auth.models
import django.contrib.auth.validators
from django.db import migrations, models
import django.db.models.deletion
import django.utils.timezone


class Migration(migrations.Migration):

dependencies = [
('auth', '0012_alter_user_first_name_max_length'),
('db', '0001_initial'),
]

operations = [
migrations.CreateModel(
name='User',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('password', models.CharField(max_length=128, verbose_name='password')),
('last_login', models.DateTimeField(blank=True, null=True, verbose_name='last login')),
('is_superuser', models.BooleanField(default=False, help_text='Designates that this user has all permissions without explicitly assigning them.', verbose_name='superuser status')),
('username', models.CharField(error_messages={'unique': 'A user with that username already exists.'}, help_text='Required. 150 characters or fewer. Letters, digits and @/./+/-/_ only.', max_length=150, unique=True, validators=[django.contrib.auth.validators.UnicodeUsernameValidator()], verbose_name='username')),
('first_name', models.CharField(blank=True, max_length=150, verbose_name='first name')),
('last_name', models.CharField(blank=True, max_length=150, verbose_name='last name')),
('email', models.EmailField(blank=True, max_length=254, verbose_name='email address')),
('is_staff', models.BooleanField(default=False, help_text='Designates whether the user can log into this admin site.', verbose_name='staff status')),
('is_active', models.BooleanField(default=True, help_text='Designates whether this user should be treated as active. Unselect this instead of deleting accounts.', verbose_name='active')),
('date_joined', models.DateTimeField(default=django.utils.timezone.now, verbose_name='date joined')),
('groups', models.ManyToManyField(blank=True, help_text='The groups this user belongs to. A user will get all permissions granted to each of their groups.', related_name='user_set', related_query_name='user', to='auth.Group', verbose_name='groups')),
('user_permissions', models.ManyToManyField(blank=True, help_text='Specific permissions for this user.', related_name='user_set', related_query_name='user', to='auth.Permission', verbose_name='user permissions')),
],
options={
'verbose_name': 'user',
'verbose_name_plural': 'users',
'abstract': False,
},
managers=[
('objects', django.contrib.auth.models.UserManager()),
],
),
migrations.CreateModel(
name='Order',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('created_at', models.DateTimeField(auto_now_add=True)),
('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='orders', to=settings.AUTH_USER_MODEL)),
],
options={
'ordering': ('-created_at',),
},
),
migrations.AlterField(
model_name='movie',
name='actors',
field=models.ManyToManyField(related_name='movies', to='db.Actor'),
),
migrations.AlterField(
model_name='movie',
name='genres',
field=models.ManyToManyField(related_name='movies', to='db.Genre'),
),
migrations.AlterField(
model_name='movie',
name='title',
field=models.CharField(db_index=True, max_length=255),
),
migrations.AlterField(
model_name='moviesession',
name='cinema_hall',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.cinemahall'),
),
migrations.AlterField(
model_name='moviesession',
name='movie',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.movie'),
),
migrations.CreateModel(
name='Ticket',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('row', models.IntegerField()),
('seat', models.IntegerField()),
('movie_session', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.moviesession')),
('order', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.order')),
],
),
migrations.AddConstraint(
model_name='ticket',
constraint=models.UniqueConstraint(fields=('row', 'seat', 'movie_session'), name='unique_movie_session'),
),
]
60 changes: 58 additions & 2 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
from django.contrib.auth import get_user_model
from django.contrib.auth.models import AbstractUser
from django.core.exceptions import ValidationError
from django.db import models
from django.db.models import UniqueConstraint


class User(AbstractUser):
pass
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved


class Genre(models.Model):
Expand All @@ -17,7 +25,7 @@ def __str__(self) -> str:


class Movie(models.Model):
title = models.CharField(max_length=255)
title = models.CharField(max_length=255, db_index=True)
description = models.TextField()
actors = models.ManyToManyField(to=Actor, related_name="movies")
genres = models.ManyToManyField(to=Genre, related_name="movies")
Expand Down Expand Up @@ -49,4 +57,52 @@ class MovieSession(models.Model):
)

def __str__(self) -> str:
return f"{self.movie.title} {str(self.show_time)}"
return f"{self.movie.title} {self.show_time}"


class Order(models.Model):
created_at = models.DateTimeField(auto_now_add=True)
user = models.ForeignKey(to=get_user_model(),
on_delete=models.CASCADE,
related_name="orders")

class Meta:
ordering = ("-created_at",)
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved

def __str__(self) -> str:
return f"{self.created_at}"


class Ticket(models.Model):
movie_session = models.ForeignKey(MovieSession, on_delete=models.CASCADE)
order = models.ForeignKey(Order, on_delete=models.CASCADE)
row = models.IntegerField()
seat = models.IntegerField()

class Meta:
constraints = [UniqueConstraint(
fields=["row", "seat", "movie_session"],
name="unique_movie_session")]
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved

def __str__(self) -> str:
return (f"{self.movie_session.movie.title} "
f"{self.movie_session.show_time} "
f"(row: {self.row}, seat: {self.seat})")

def clean(self) -> None:
if self.row > self.movie_session.cinema_hall.rows:
raise ValidationError({
"row": [f"row number must be "
f"in available range: "
f"(1, rows): (1, "
f"{self.movie_session.cinema_hall.rows})"]
})
if self.seat > self.movie_session.cinema_hall.seats_in_row:
raise ValidationError({
"seat": [f"seat number must be in available "
f"range: (1, seats_in_row): (1, "
f"{self.movie_session.cinema_hall.seats_in_row})"]})

def save(self, *args, **kwargs) -> None:
self.full_clean()
super().save(*args, **kwargs)
26 changes: 16 additions & 10 deletions services/movie.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from django.db import transaction
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved
from django.db.models import QuerySet

from db.models import Movie
Expand All @@ -6,6 +7,7 @@
def get_movies(
genres_ids: list[int] = None,
actors_ids: list[int] = None,
title: str = None,
) -> QuerySet:
queryset = Movie.objects.all()

Expand All @@ -15,6 +17,9 @@ def get_movies(
if actors_ids:
queryset = queryset.filter(actors__id__in=actors_ids)

if title:
queryset = queryset.filter(title__icontains=title)

return queryset


Expand All @@ -28,13 +33,14 @@ def create_movie(
genres_ids: list = None,
actors_ids: list = None,
) -> Movie:
movie = Movie.objects.create(
title=movie_title,
description=movie_description,
)
if genres_ids:
movie.genres.set(genres_ids)
if actors_ids:
movie.actors.set(actors_ids)

return movie
with transaction.atomic():
movie = Movie.objects.create(
title=movie_title,
description=movie_description,
)
if genres_ids:
movie.genres.set(genres_ids)
if actors_ids:
movie.actors.set(actors_ids)

return movie
Comment on lines +36 to +46
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use transaction.atomic as decorator instead of context manager. It will make your code more readable

8 changes: 6 additions & 2 deletions services/movie_session.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from django.db.models import QuerySet

from db.models import MovieSession
from db.models import MovieSession, Ticket


def create_movie_session(
Expand Down Expand Up @@ -42,3 +41,8 @@ def update_movie_session(

def delete_movie_session_by_id(session_id: int) -> None:
MovieSession.objects.get(id=session_id).delete()


def get_taken_seats(movie_session_id: int) -> list[dict]:
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved
return list(Ticket.objects.filter(
movie_session_id=movie_session_id).values("row", "seat"))
45 changes: 45 additions & 0 deletions services/order.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
from django.db import transaction
from django.db.models import QuerySet
from db.models import Ticket, Order, get_user_model, MovieSession


def create_order(tickets: list[dict],
username: str,
date: str = None) -> None:

with transaction.atomic():

user = get_user_model().objects.get(username=username)
order = Order.objects.create(user=user)
tickets_instances = []
if date:
order.created_at = date
Comment on lines +10 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use transaction.atomic as decorator instead of context manager. It will make your code more readable

order.save()
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved

for ticket in tickets:
movie_session = MovieSession.objects.get(
pk=ticket["movie_session"]
)
hall = movie_session.cinema_hall
seats = hall.seats_in_row
rows = hall.rows

if ticket["seat"] > seats:
raise ValueError(f"Seat number exceeds limit: {seats} seats.")
if ticket["row"] > rows:
raise ValueError(f"Row number exceeds limit: {rows} rows.")

tickets_instances.append(
Ticket(movie_session_id=ticket["movie_session"],
order=order,
row=ticket["row"],
seat=ticket["seat"])
)
Ticket.objects.bulk_create(tickets_instances)


def get_orders(username: str = None) -> QuerySet:
if username:
user = get_user_model().objects.get(username=username)
return Order.objects.filter(user=user)
return Order.objects.all()
54 changes: 54 additions & 0 deletions services/user.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
from db.models import get_user_model, User
Serhii-Chubur marked this conversation as resolved.
Show resolved Hide resolved


def create_user(username: str,
password: str,
email: str = None,
first_name: str = None,
last_name: str = None,
) -> User:
user = get_user_model().objects.create_user(
username=username,
password=password
)
if email:
user.email = email

if first_name:
user.first_name = first_name

if last_name:
user.last_name = last_name

user.save()
return user


def get_user(user_id: int) -> User:
return get_user_model().objects.get(pk=user_id)


def update_user(user_id: int,
username: str = None,
password: str = None,
email: str = None,
first_name: str = None,
last_name: str = None) -> User:
user = get_user_model().objects.get(pk=user_id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use get_user here

if username:
user.username = username

if password:
user.set_password(password)

if email:
user.email = email

if first_name:
user.first_name = first_name

if last_name:
user.last_name = last_name

user.save()
return user
4 changes: 4 additions & 0 deletions settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,8 @@

INSTALLED_APPS = [
"db",
"django.contrib.auth",
"django.contrib.contenttypes",
]

AUTH_USER_MODEL = "db.User"
Loading