Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished #917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# Generated by Django 4.0.2 on 2024-10-21 21:07

from django.conf import settings
import django.contrib.auth.models
import django.contrib.auth.validators
from django.db import migrations, models
import django.db.models.deletion
import django.utils.timezone


class Migration(migrations.Migration):

dependencies = [
('auth', '0012_alter_user_first_name_max_length'),
('db', '0001_initial'),
]

operations = [
migrations.CreateModel(
name='User',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('password', models.CharField(max_length=128, verbose_name='password')),
('last_login', models.DateTimeField(blank=True, null=True, verbose_name='last login')),
('is_superuser', models.BooleanField(default=False, help_text='Designates that this user has all permissions without explicitly assigning them.', verbose_name='superuser status')),
('username', models.CharField(error_messages={'unique': 'A user with that username already exists.'}, help_text='Required. 150 characters or fewer. Letters, digits and @/./+/-/_ only.', max_length=150, unique=True, validators=[django.contrib.auth.validators.UnicodeUsernameValidator()], verbose_name='username')),
('first_name', models.CharField(blank=True, max_length=150, verbose_name='first name')),
('last_name', models.CharField(blank=True, max_length=150, verbose_name='last name')),
('email', models.EmailField(blank=True, max_length=254, verbose_name='email address')),
('is_staff', models.BooleanField(default=False, help_text='Designates whether the user can log into this admin site.', verbose_name='staff status')),
('is_active', models.BooleanField(default=True, help_text='Designates whether this user should be treated as active. Unselect this instead of deleting accounts.', verbose_name='active')),
('date_joined', models.DateTimeField(default=django.utils.timezone.now, verbose_name='date joined')),
('groups', models.ManyToManyField(blank=True, help_text='The groups this user belongs to. A user will get all permissions granted to each of their groups.', related_name='user_set', related_query_name='user', to='auth.Group', verbose_name='groups')),
('user_permissions', models.ManyToManyField(blank=True, help_text='Specific permissions for this user.', related_name='user_set', related_query_name='user', to='auth.Permission', verbose_name='user permissions')),
],
options={
'verbose_name': 'user',
'verbose_name_plural': 'users',
'abstract': False,
},
managers=[
('objects', django.contrib.auth.models.UserManager()),
],
),
migrations.CreateModel(
name='Order',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('created_at', models.DateTimeField(auto_now_add=True)),
('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='orders', to=settings.AUTH_USER_MODEL)),
],
options={
'ordering': ['-created_at'],
},
),
migrations.AlterField(
model_name='movie',
name='actors',
field=models.ManyToManyField(related_name='movies', to='db.Actor'),
),
migrations.AlterField(
model_name='movie',
name='genres',
field=models.ManyToManyField(related_name='movies', to='db.Genre'),
),
migrations.AlterField(
model_name='movie',
name='title',
field=models.CharField(db_index=True, max_length=255),
),
migrations.AlterField(
model_name='moviesession',
name='cinema_hall',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.cinemahall'),
),
migrations.AlterField(
model_name='moviesession',
name='movie',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='movie_sessions', to='db.movie'),
),
migrations.CreateModel(
name='Ticket',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('row', models.IntegerField()),
('seat', models.IntegerField()),
('movie_session', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.moviesession')),
('order', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='db.order')),
],
),
migrations.AddConstraint(
model_name='ticket',
constraint=models.UniqueConstraint(fields=('movie_session', 'row', 'seat'), name='unique_ticket_per_seat'),
),
]
73 changes: 70 additions & 3 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
from django.core.exceptions import ValidationError
from django.db import models
from django.contrib.auth.models import AbstractUser
from django.conf import settings


class Genre(models.Model):
Expand All @@ -17,7 +20,7 @@ def __str__(self) -> str:


class Movie(models.Model):
title = models.CharField(max_length=255)
title = models.CharField(max_length=255, db_index=True)
description = models.TextField()
actors = models.ManyToManyField(to=Actor, related_name="movies")
genres = models.ManyToManyField(to=Genre, related_name="movies")
Expand All @@ -42,11 +45,75 @@ def __str__(self) -> str:
class MovieSession(models.Model):
show_time = models.DateTimeField()
cinema_hall = models.ForeignKey(
to=CinemaHall, on_delete=models.CASCADE, related_name="movie_sessions"
to=CinemaHall,
on_delete=models.CASCADE,
related_name="movie_sessions"
)
movie = models.ForeignKey(
to=Movie, on_delete=models.CASCADE, related_name="movie_sessions"
to=Movie,
on_delete=models.CASCADE,
related_name="movie_sessions"
)

def __str__(self) -> str:
return f"{self.movie.title} {str(self.show_time)}"


class Order(models.Model):
created_at = models.DateTimeField(auto_now_add=True)
user = models.ForeignKey(
settings.AUTH_USER_MODEL,
on_delete=models.CASCADE,
related_name="orders"
)

def __str__(self) -> str:
return f"<Order: {self.created_at}>"

class Meta:
ordering = ["-created_at"]
Comment on lines +73 to +74

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'class Meta' should be placed after all the attributes of the class are defined. This is correct in this case, but make sure to follow this pattern consistently.



class User(AbstractUser):
pass


class Ticket(models.Model):
movie_session = models.ForeignKey(to=MovieSession,
on_delete=models.CASCADE)
order = models.ForeignKey(to=Order, on_delete=models.CASCADE)
row = models.IntegerField()
seat = models.IntegerField()

class Meta:
constraints = [
models.UniqueConstraint(
fields=["movie_session", "row", "seat"],
name="unique_ticket_per_seat"
)
]

def clean(self) -> None:
cinema_hall = self.movie_session.cinema_hall

if self.row < 1 or self.row > cinema_hall.rows:
raise ValidationError(
f"Row number {self.row} is invalid. "
f"This cinema hall has {cinema_hall.rows} rows."
)

if self.seat < 1 or self.seat > cinema_hall.seats_in_row:
raise ValidationError(
f"Seat number {self.seat} is invalid. "
f"Each row has {cinema_hall.seats_in_row} seats."
)

def save(self, *args, **kwargs) -> None:
self.full_clean()
super().save(*args, **kwargs)

def __str__(self) -> str:
return (
f"<Ticket: {self.movie_session} "
f"(row: {self.row}, seat: {self.seat})>"
)
27 changes: 17 additions & 10 deletions services/movie.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from django.db import transaction
from django.db.models import QuerySet

from db.models import Movie


def get_movies(
genres_ids: list[int] = None,
actors_ids: list[int] = None,
title: str = None,
) -> QuerySet:
queryset = Movie.objects.all()

Expand All @@ -15,6 +16,9 @@ def get_movies(
if actors_ids:
queryset = queryset.filter(actors__id__in=actors_ids)

if title:
queryset = queryset.filter(title__icontains=title)

return queryset


Expand All @@ -28,13 +32,16 @@ def create_movie(
genres_ids: list = None,
actors_ids: list = None,
) -> Movie:
movie = Movie.objects.create(
title=movie_title,
description=movie_description,
)
if genres_ids:
movie.genres.set(genres_ids)
if actors_ids:
movie.actors.set(actors_ids)
with transaction.atomic():
movie = Movie.objects.create(
title=movie_title,
description=movie_description,
)

if genres_ids:
movie.genres.set(genres_ids)

if actors_ids:
movie.actors.set(actors_ids)

return movie
return movie
12 changes: 11 additions & 1 deletion services/movie_session.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.db.models import QuerySet

from db.models import MovieSession
from db.models import MovieSession, Ticket

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using double quotes for consistency in the import statement, as per the code style checklist.



def create_movie_session(
Expand Down Expand Up @@ -42,3 +42,13 @@ def update_movie_session(

def delete_movie_session_by_id(session_id: int) -> None:
MovieSession.objects.get(id=session_id).delete()


def get_taken_seats(movie_session_id: int) -> list[dict]:

tickets = Ticket.objects.filter(movie_session_id=movie_session_id)

taken_seats = [{"row": ticket.row,
"seat": ticket.seat} for ticket in tickets]

return taken_seats
52 changes: 52 additions & 0 deletions services/order.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
from django.db import transaction
from django.utils import timezone
from django.core.exceptions import ObjectDoesNotExist
from db.models import Order, Ticket, MovieSession, User

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use get_user_model() instead of directly importing User. This aligns with the checklist item: 'Use get_user_model() instead of User, it is the best practice.'



def create_order(tickets: list[dict], username: str,
date: str = None) -> Order:
try:
user = User.objects.get(username=username)
except ObjectDoesNotExist:
raise ValueError(
f"User with username {username} does not exist."
)

with transaction.atomic():
order = Order.objects.create(
user=user,
created_at=date if date else timezone.now()
)

# Create tickets associated with the order
for ticket_data in tickets:
row = ticket_data.get("row")
seat = ticket_data.get("seat")
movie_session_id = ticket_data.get("movie_session")

try:
movie_session = MovieSession.objects.get(id=movie_session_id)
except ObjectDoesNotExist:
raise ValueError(
f"Movie session with id {movie_session_id} does not exist."
)

Ticket.objects.create(
row=row,
seat=seat,
movie_session=movie_session,
order=order
)

return order


def get_orders(username: str = None) -> list[Order]:
if username:
try:
user = User.objects.get(username=username)
return Order.objects.filter(user=user).order_by("-created_at")
except ObjectDoesNotExist:
return []
return Order.objects.all().order_by("-created_at")
59 changes: 59 additions & 0 deletions services/user.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
from django.contrib.auth import get_user_model
from django.core.exceptions import ObjectDoesNotExist

User = get_user_model()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should use get_user_model() directly instead of assigning it to User. This is to ensure that the most current user model is always used.



def create_user(
username: str,
password: str,
email: str = None,
first_name: str = None,
last_name: str = None
) -> User:
user = User.objects.create_user(username=username, password=password)

if email:
user.email = email
if first_name:
user.first_name = first_name
if last_name:
user.last_name = last_name

user.save()
return user


def get_user(user_id: int) -> User:
try:
return User.objects.get(id=user_id)
except ObjectDoesNotExist:
return None


def update_user(
user_id: int,
username: str = None,
password: str = None,
email: str = None,
first_name: str = None,
last_name: str = None
) -> User:
try:
user = User.objects.get(id=user_id)

if username:
user.username = username
if password:
user.set_password(password)
if email:
user.email = email
if first_name:
user.first_name = first_name
if last_name:
user.last_name = last_name

user.save()
return user
except ObjectDoesNotExist:
return None
4 changes: 4 additions & 0 deletions settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@
USE_TZ = False

INSTALLED_APPS = [
"django.contrib.auth",
"django.contrib.contenttypes",
"db",
]

AUTH_USER_MODEL = "db.User"
Loading