Complete Task #1726
Complete Task #1726
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 Your code is well-structured and meets the core functionality needed for the application. While there are a few minor improvements suggested, such as using a unique identifier for keys and ensuring optional properties are checked before access, these do not hinder the overall functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| {currPerson.mother ? ( | ||
| <a | ||
| className="has-text-danger" | ||
| href={`#/people/${currPerson.mother?.slug}`} |
There was a problem hiding this comment.
Ensure that currPerson.mother?.slug is defined before accessing it. If slug is not guaranteed to be present, consider adding a check or default value.
|
|
||
| <td> | ||
| {currPerson.father ? ( | ||
| <a href={`#/people/${currPerson.father.slug}`}> |
There was a problem hiding this comment.
Ensure that currPerson.father.slug is defined before accessing it. If slug is not guaranteed to be present, consider adding a check or default value.
|
|
||
| <tbody> | ||
| {people.map((person, index) => ( | ||
| <PeopleItem key={index} person={person} /> |
There was a problem hiding this comment.
Consider using a unique identifier from the person object, such as person.id or person.slug, for the key prop instead of the array index. This helps React optimize rendering performance.
|
|
||
| export const PeopleContext = createContext({ | ||
| isError: false, | ||
| getPeopleFromServer: () => {}, |
There was a problem hiding this comment.
Consider defining getPeopleFromServer as a no-op function like () => {} in the default context value to prevent potential errors if it's called before the PeopleProvider is mounted.
DEMO LINK