solve #1736
solve #1736
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 While there are a few minor issues, such as the use of person.name as a key and potential confusion with nested routes, these do not critically impact the functionality. Consider addressing these in future iterations for improved code quality. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <Route path="people"> | ||
| <Route index element={<People />} /> | ||
| <Route path=":peopleId" element={<People />} /> | ||
| </Route> |
There was a problem hiding this comment.
The nested routes under /people might cause confusion. The People component is used for both the index route and the :peopleId route. Ensure that the People component can handle both cases appropriately, or consider using different components if they serve different purposes.
| <tr | ||
| key={person.name} |
There was a problem hiding this comment.
Using person.name as a key might not be unique if there are multiple people with the same name. Consider using a unique identifier, such as person.slug or another unique property, to ensure that each element has a unique key.
| father: peopleFromServer.find(p => p.name === person.fatherName), | ||
| mother: peopleFromServer.find(p => p.name === person.motherName), |
There was a problem hiding this comment.
The logic for finding a person's father and mother by name may lead to incorrect associations if there are multiple people with the same name. Consider using a unique identifier for each person to ensure accurate parent-child relationships.
|
|
||
| <tbody> | ||
| {people.map(person => ( | ||
| <PersonLink key={person.name} person={person} /> |
There was a problem hiding this comment.
Using person.name as a key might not be unique if there are multiple people with the same name. Consider using a unique identifier, such as person.slug or another unique property, to ensure that each element has a unique key.
DEMO LINK