Todo App #1571
Open
Todo App #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasSokolov1
suggested changes
Dec 27, 2024
Comment on lines
+229
to
+257
| <button | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'all', | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter(Filter.All)} | ||
| > | ||
| All | ||
| </button> | ||
|
|
||
| <button | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'active', | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter(Filter.Active)} | ||
| > | ||
| Active | ||
| </button> | ||
|
|
||
| <button | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'completed', | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter(Filter.Completed)} | ||
| > | ||
| Completed | ||
| </button> |
There was a problem hiding this comment.
let's show these elements using .map()
| export const USER_ID = 2171; | ||
|
|
||
| export const getTodos = () => { | ||
| return client.get<Todo[]>(`/todos?userId=${USER_ID}`); |
Comment on lines
+152
to
+160
| activeTodos.forEach(todo => { | ||
| onUpdateTodo({ ...todo, completed: true }); | ||
| }); | ||
| setIsToogleAll(true); | ||
| } else { | ||
| todos.forEach(todo => { | ||
| onUpdateTodo({ ...todo, completed: false }); | ||
| }); | ||
| setIsToogleAll(false); |
There was a problem hiding this comment.
seems very similar can let's write one time and just change true or false depends on unCompletedTodos counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK